Skip to content

Commit

Permalink
fix(typescript-estree): correct type of key for base nodes (#1367)
Browse files Browse the repository at this point in the history
  • Loading branch information
armano2 authored and bradzacher committed Dec 21, 2019
1 parent bd0276b commit 099225a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions packages/typescript-estree/src/ts-estree/ts-estree.ts
Expand Up @@ -521,7 +521,7 @@ interface ClassDeclarationBase extends BaseNode {

/** this should not be directly used - instead use ClassPropertyComputedNameBase or ClassPropertyNonComputedNameBase */
interface ClassPropertyBase extends BaseNode {
key: PropertyNameComputed | PropertyNameComputed;
key: PropertyName;
value: Expression | null;
computed: boolean;
static: boolean;
Expand Down Expand Up @@ -591,7 +591,7 @@ interface MemberExpressionNonComputedNameBase extends MemberExpressionBase {

/** this should not be directly used - instead use MethodDefinitionComputedNameBase or MethodDefinitionNonComputedNameBase */
interface MethodDefinitionBase extends BaseNode {
key: PropertyNameComputed | PropertyNameComputed;
key: PropertyName;
value: FunctionExpression | TSEmptyBodyFunctionExpression;
computed: boolean;
static: boolean;
Expand All @@ -613,7 +613,7 @@ interface MethodDefinitionNonComputedNameBase extends MethodDefinitionBase {

interface PropertyBase extends BaseNode {
type: AST_NODE_TYPES.Property;
key: PropertyNameComputed | PropertyNameNonComputed;
key: PropertyName;
value: Expression | AssignmentPattern | BindingName;
computed: boolean;
method: boolean;
Expand All @@ -638,7 +638,7 @@ interface TSHeritageBase extends BaseNode {

interface TSMethodSignatureBase extends BaseNode {
type: AST_NODE_TYPES.TSMethodSignature;
key: PropertyNameComputed | PropertyNameNonComputed;
key: PropertyName;
computed: boolean;
params: Parameter[];
optional?: boolean;
Expand All @@ -652,7 +652,7 @@ interface TSMethodSignatureBase extends BaseNode {

interface TSPropertySignatureBase extends BaseNode {
type: AST_NODE_TYPES.TSPropertySignature;
key: PropertyNameComputed | PropertyNameNonComputed;
key: PropertyName;
optional?: boolean;
computed: boolean;
typeAnnotation?: TSTypeAnnotation;
Expand Down

0 comments on commit 099225a

Please sign in to comment.