fix(eslint-plugin): [prefer-readonly] TypeError when having comp… (#761)

typescript-eslint · Jul 25, 2019 · 211b1b5 · 211b1b5
1 parent 2b942ba
commit 211b1b5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/prefer-readonly.ts b/packages/eslint-plugin/src/rules/prefer-readonly.ts
@@ -179,7 +179,7 @@ export default util.createRule<Options, MessageIds>({
         const tsNode = parserServices.esTreeNodeToTSNodeMap.get<
           ts.PropertyAccessExpression
         >(node);
-        if (classScopeStack.length !== 0) {
+        if (classScopeStack.length !== 0 && !node.computed) {
           handlePropertyAccessExpression(
             tsNode,
             tsNode.parent,

diff --git a/packages/eslint-plugin/tests/rules/prefer-readonly.test.ts b/packages/eslint-plugin/tests/rules/prefer-readonly.test.ts
@@ -215,6 +215,11 @@ ruleTester.run('prefer-readonly', rule, {
         },
       ],
     },
+    `class TestComputedParameter {
+      public mutate() {
+        this['computed'] = 1;
+      }
+    }`,
   ],
   invalid: [
     {