fix(eslint-plugin): [prefer-for-of] do nor error when iterating over …

…this (#4176) * fix(eslint-plugin): [prefer-for-of] do not error when used on this expression * fix(eslint-plugin): [prefer-for-of] add missing test case * fix(eslint-plugin): [prefer-for-of] do nor error when iterating over this
typescript-eslint · Nov 23, 2021 · 258ddb0 · 258ddb0
1 parent f8e9125
commit 258ddb0
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/prefer-for-of.ts b/packages/eslint-plugin/src/rules/prefer-for-of.ts
@@ -174,6 +174,7 @@ export default util.createRule({
           !contains(body, id) ||
           (node !== undefined &&
             node.type === AST_NODE_TYPES.MemberExpression &&
+            node.object.type !== AST_NODE_TYPES.ThisExpression &&
             node.property === id &&
             sourceCode.getText(node.object) === arrayText &&
             !isAssignee(node))

diff --git a/packages/eslint-plugin/tests/rules/prefer-for-of.test.ts b/packages/eslint-plugin/tests/rules/prefer-for-of.test.ts
@@ -180,6 +180,16 @@ for (var c = 0; c < arr.length; c++) {
     `
 for (var d = 0; d < arr.length; d++) doMath?.(d);
     `,
+    `
+for (let i = 0; i < test.length; ++i) {
+  this[i];
+}
+    `,
+    `
+for (let i = 0; i < this.length; ++i) {
+  yield this[i];
+}
+    `,
   ],
   invalid: [
     {
@@ -357,6 +367,30 @@ for (let i = 0; i < arr.length; i++) {
       code: `
 for (let i = 0; i < arr.length; i++) {
   ({ foo: obj[arr[i]] } = { foo: 1 });
+}
+      `,
+      errors: [
+        {
+          messageId: 'preferForOf',
+        },
+      ],
+    },
+    {
+      code: `
+for (let i = 0; i < this.item.length; ++i) {
+  this.item[i];
+}
+      `,
+      errors: [
+        {
+          messageId: 'preferForOf',
+        },
+      ],
+    },
+    {
+      code: `
+for (let i = 0; i < this.array.length; ++i) {
+  yield this.array[i];
 }
       `,
       errors: [