fix(eslint-plugin): [unbound-method] false positive in equality compa…

…risons (#914)
typescript-eslint · Aug 28, 2019 · 29a01b8 · 29a01b8
1 parent 344bafe
commit 29a01b8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/unbound-method.ts b/packages/eslint-plugin/src/rules/unbound-method.ts
@@ -123,6 +123,9 @@ function isSafeUse(node: TSESTree.Node): boolean {
     case AST_NODE_TYPES.UnaryExpression:
       return parent.operator === 'typeof';
 
+    case AST_NODE_TYPES.BinaryExpression:
+      return ['instanceof', '==', '!=', '===', '!=='].includes(parent.operator);
+
     case AST_NODE_TYPES.TSNonNullExpression:
     case AST_NODE_TYPES.TSAsExpression:
     case AST_NODE_TYPES.TSTypeAssertion:

diff --git a/packages/eslint-plugin/tests/rules/unbound-method.test.ts b/packages/eslint-plugin/tests/rules/unbound-method.test.ts
@@ -52,15 +52,27 @@ instance.unbound\`\`;
 if (instance.bound) { }
 if (instance.unbound) { }
 
+if (instance.bound !== undefined) { }
+if (instance.unbound !== undefined) { }
+
 if (ContainsMethods.boundStatic) { }
 if (ContainsMethods.unboundStatic) { }
 
+if (ContainsMethods.boundStatic !== undefined) { }
+if (ContainsMethods.unboundStatic !== undefined) { }
+
 while (instance.bound) { }
 while (instance.unbound) { }
 
+while (instance.bound !== undefined) { }
+while (instance.unbound !== undefined) { }
+
 while (ContainsMethods.boundStatic) { }
 while (ContainsMethods.unboundStatic) { }
 
+while (ContainsMethods.boundStatic !== undefined) { }
+while (ContainsMethods.unboundStatic !== undefined) { }
+
 instance.bound as any;
 ContainsMethods.boundStatic as any;