From 2f90a5b8bca3aa9417c1960208b90a48948cdff4 Mon Sep 17 00:00:00 2001 From: Brad Zacher Date: Sun, 10 May 2020 14:16:31 -0700 Subject: [PATCH] feat(eslint-plugin): [restrict-template-expressions] `allowNumber: true` by default (#2005) --- .../docs/rules/restrict-template-expressions.md | 3 ++- .../src/rules/restrict-template-expressions.ts | 6 +++++- .../tests/rules/restrict-template-expressions.test.ts | 2 ++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/eslint-plugin/docs/rules/restrict-template-expressions.md b/packages/eslint-plugin/docs/rules/restrict-template-expressions.md index 816a0b0f9d6..260a8eb188d 100644 --- a/packages/eslint-plugin/docs/rules/restrict-template-expressions.md +++ b/packages/eslint-plugin/docs/rules/restrict-template-expressions.md @@ -38,8 +38,9 @@ type Options = { }; const defaults = { - allowNumber: false, + allowNumber: true, allowBoolean: false, + allowAny: false, allowNullable: false, }; ``` diff --git a/packages/eslint-plugin/src/rules/restrict-template-expressions.ts b/packages/eslint-plugin/src/rules/restrict-template-expressions.ts index a3ec4cfd7d3..191eb0efe64 100644 --- a/packages/eslint-plugin/src/rules/restrict-template-expressions.ts +++ b/packages/eslint-plugin/src/rules/restrict-template-expressions.ts @@ -41,7 +41,11 @@ export default util.createRule({ }, ], }, - defaultOptions: [{}], + defaultOptions: [ + { + allowNumber: true, + }, + ], create(context, [options]) { const service = util.getParserServices(context); const typeChecker = service.program.getTypeChecker(); diff --git a/packages/eslint-plugin/tests/rules/restrict-template-expressions.test.ts b/packages/eslint-plugin/tests/rules/restrict-template-expressions.test.ts index 2f5900f3d2a..d3328bded56 100644 --- a/packages/eslint-plugin/tests/rules/restrict-template-expressions.test.ts +++ b/packages/eslint-plugin/tests/rules/restrict-template-expressions.test.ts @@ -214,6 +214,7 @@ ruleTester.run('restrict-template-expressions', rule, { code: ` const msg = \`arg = \${123}\`; `, + options: [{ allowNumber: false }], errors: [{ messageId: 'invalidType', line: 2, column: 30 }], }, { @@ -233,6 +234,7 @@ ruleTester.run('restrict-template-expressions', rule, { declare const arg: number; const msg = \`arg = \${arg}\`; `, + options: [{ allowNumber: false }], errors: [{ messageId: 'invalidType', line: 3, column: 30 }], }, {