fix(eslint-plugin): [triple-slash-reference] fix crash with external …

…module reference (#2788)
typescript-eslint · Nov 25, 2020 · 32b1b68 · 32b1b68
1 parent c816b84
commit 32b1b68
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/triple-slash-reference.ts b/packages/eslint-plugin/src/rules/triple-slash-reference.ts
@@ -1,4 +1,5 @@
 import {
+  AST_NODE_TYPES,
   AST_TOKEN_TYPES,
   TSESTree,
 } from '@typescript-eslint/experimental-utils';
@@ -81,9 +82,11 @@ export default util.createRule<Options, MessageIds>({
       },
       TSImportEqualsDeclaration(node): void {
         if (programNode) {
-          const source = (node.moduleReference as TSESTree.TSExternalModuleReference)
-            .expression as TSESTree.Literal;
-          hasMatchingReference(source);
+          const reference = node.moduleReference;
+
+          if (reference.type === AST_NODE_TYPES.TSExternalModuleReference) {
+            hasMatchingReference(reference.expression as TSESTree.Literal);
+          }
         }
       },
       Program(node): void {

diff --git a/packages/eslint-plugin/tests/rules/triple-slash-reference.test.ts b/packages/eslint-plugin/tests/rules/triple-slash-reference.test.ts
@@ -54,6 +54,28 @@ ruleTester.run('triple-slash-reference', rule, {
       `,
       options: [{ path: 'always', types: 'always', lib: 'always' }],
     },
+    {
+      code: `
+        /// <reference path="foo" />
+        /// <reference types="bar" />
+        /// <reference lib="baz" />
+        import foo = foo;
+        import bar = bar;
+        import baz = baz;
+      `,
+      options: [{ path: 'always', types: 'always', lib: 'always' }],
+    },
+    {
+      code: `
+        /// <reference path="foo" />
+        /// <reference types="bar" />
+        /// <reference lib="baz" />
+        import foo = foo.foo;
+        import bar = bar.bar.bar.bar;
+        import baz = baz.baz;
+      `,
+      options: [{ path: 'always', types: 'always', lib: 'always' }],
+    },
     {
       code: "import * as foo from 'foo';",
       options: [{ path: 'never' }],