fix(typescript-estree): support override modifier for parameter prope…

…rty (#3485)
typescript-eslint · Jun 9, 2021 · 33b9f69 · 33b9f69
1 parent 44452dd
commit 33b9f69
Show file tree

Hide file tree

Showing 16 changed files with 1,249 additions and 0 deletions.
diff --git a/packages/ast-spec/src/parameter/TSParameterProperty/spec.ts b/packages/ast-spec/src/parameter/TSParameterProperty/spec.ts
@@ -12,6 +12,7 @@ export interface TSParameterProperty extends BaseNode {
   readonly?: boolean;
   static?: boolean;
   export?: boolean;
+  override?: boolean;
   parameter: AssignmentPattern | BindingName | RestElement;
   decorators?: Decorator[];
 }
diff --git a/...res/typescript/basics/class-with-constructor-and-parameter-property-with-modifiers.src.ts b/...res/typescript/basics/class-with-constructor-and-parameter-property-with-modifiers.src.ts
@@ -0,0 +1,3 @@
+class SpecializedComponent extends SomeComponent {
+  constructor(protected override readonly param: string) {}
+}
diff --git a/...script/basics/class-with-constructor-and-parameter-proptery-with-override-modifier.src.ts b/...script/basics/class-with-constructor-and-parameter-proptery-with-override-modifier.src.ts
@@ -0,0 +1,5 @@
+class SpecializedComponent extends SomeComponent {
+  constructor(override param: string) {
+      super();
+  }
+}
diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -1585,6 +1585,8 @@ export class Converter {
               hasModifier(SyntaxKind.ReadonlyKeyword, node) || undefined,
             static: hasModifier(SyntaxKind.StaticKeyword, node) || undefined,
             export: hasModifier(SyntaxKind.ExportKeyword, node) || undefined,
+            override:
+              hasModifier(SyntaxKind.OverrideKeyword, node) || undefined,
             parameter: result,
           });
         }

diff --git a/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts b/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts
@@ -386,6 +386,12 @@ tester.addFixturePatternConfig('typescript/basics', {
      * This is intentional; babel is not checking types
      */
     'catch-clause-with-invalid-annotation',
+    /**
+     * [BABEL ERRORED, BUT TS-ESTREE DID NOT]
+     * SyntaxError: Unexpected token, expected ","
+     */
+    'class-with-constructor-and-parameter-property-with-modifiers',
+    'class-with-constructor-and-parameter-proptery-with-override-modifier',
   ],
   ignoreSourceType: [
     /**

diff --git a/packages/typescript-estree/tests/lib/__snapshots__/semantic-diagnostics-enabled.test.ts.snap b/packages/typescript-estree/tests/lib/__snapshots__/semantic-diagnostics-enabled.test.ts.snap
@@ -1746,6 +1746,10 @@ exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" e
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-constructor-and-modifier.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
+exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-constructor-and-parameter-property-with-modifiers.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
+
+exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-constructor-and-parameter-proptery-with-override-modifier.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
+
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-constructor-and-return-type.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;
 
 exports[`Parse all fixtures with "errorOnTypeScriptSyntacticAndSemanticIssues" enabled fixtures/typescript/basics/class-with-constructor-and-type-parameters.src 1`] = `"TEST OUTPUT: No semantic or syntactic issues found"`;