From 35537adb8bd1c4084ccc601acb449fbd8cefcd8c Mon Sep 17 00:00:00 2001 From: duduluu Date: Sat, 4 Apr 2020 23:50:51 +0800 Subject: [PATCH] fix(eslint-plugin): fix no-base-to-string boolean literal check --- packages/eslint-plugin/src/rules/no-base-to-string.ts | 4 ++++ packages/eslint-plugin/tests/rules/no-base-to-string.test.ts | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/packages/eslint-plugin/src/rules/no-base-to-string.ts b/packages/eslint-plugin/src/rules/no-base-to-string.ts index 98a37c740849..7308fa6201a9 100644 --- a/packages/eslint-plugin/src/rules/no-base-to-string.ts +++ b/packages/eslint-plugin/src/rules/no-base-to-string.ts @@ -65,6 +65,10 @@ export default util.createRule({ return Usefulness.Always; } + if (type.flags & ts.TypeFlags.BooleanLiteral) { + return Usefulness.Always; + } + if ( toString.declarations.every( ({ parent }) => diff --git a/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts b/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts index cd2e4b166a90..5cb25971e646 100644 --- a/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts +++ b/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts @@ -30,6 +30,10 @@ ruleTester.run('no-base-to-string', rule, { "'text'.toString();", 'false.toString();', ` +let value = true; +value.toString(); + `, + ` let value = 1; value.toString(); `,