fix(eslint-plugin): handle method overloading in semi (#4318)

typescript-eslint · Dec 20, 2021 · 3b87b49 · 3b87b49
1 parent 04d1f3e
commit 3b87b49
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/semi.ts b/packages/eslint-plugin/src/rules/semi.ts
@@ -53,11 +53,11 @@ export default util.createRule<Options, MessageIds>({
     const nodesToCheck = [
       AST_NODE_TYPES.PropertyDefinition,
       AST_NODE_TYPES.TSAbstractPropertyDefinition,
-      AST_NODE_TYPES.TSAbstractMethodDefinition,
       AST_NODE_TYPES.TSDeclareFunction,
       AST_NODE_TYPES.TSExportAssignment,
       AST_NODE_TYPES.TSImportEqualsDeclaration,
       AST_NODE_TYPES.TSTypeAliasDeclaration,
+      AST_NODE_TYPES.TSEmptyBodyFunctionExpression,
     ].reduce<TSESLint.RuleListener>((acc, node) => {
       acc[node as string] = checkForSemicolon;
       return acc;

diff --git a/packages/eslint-plugin/tests/rules/semi.test.ts b/packages/eslint-plugin/tests/rules/semi.test.ts
@@ -302,7 +302,46 @@ class PanCamera extends FreeCamera {
       options: ['always', { omitLastInOneLineBlock: true }],
       errors: [extraSemicolon],
     },
+    {
+      code: `
+        class A {
+          method(): void
+          method(arg?: any): void {
+
+          }
+        }
+      `,
+      output: `
+        class A {
+          method(): void;
+          method(arg?: any): void {
 
+          }
+        }
+      `,
+      options: ['always'],
+      errors: [missingSemicolon],
+    },
+    {
+      code: `
+        class A {
+          method(): void;
+          method(arg?: any): void {
+
+          }
+        }
+      `,
+      output: `
+        class A {
+          method(): void
+          method(arg?: any): void {
+
+          }
+        }
+      `,
+      options: ['never'],
+      errors: [extraSemicolon],
+    },
     {
       code: `
         import a from "a"