fix(eslint-plugin): handle const; (#633)

Fixes #441
typescript-eslint · Jun 28, 2019 · 430d628 · 430d628
1 parent e325b72
commit 430d628
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/consistent-type-definitions.ts b/packages/eslint-plugin/src/rules/consistent-type-definitions.ts
@@ -27,7 +27,6 @@ export default util.createRule({
     const sourceCode = context.getSourceCode();
 
     return {
-      // VariableDeclaration with kind type has only one VariableDeclarator
       "TSTypeAliasDeclaration[typeAnnotation.type='TSTypeLiteral']"(
         node: TSESTree.TSTypeAliasDeclaration,
       ) {

diff --git a/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts b/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts
@@ -1382,6 +1382,10 @@ export default createRule<Options, MessageIds>({
       },
 
       VariableDeclaration(node) {
+        if (node.declarations.length === 0) {
+          return;
+        }
+
         let variableIndent = Object.prototype.hasOwnProperty.call(
           options.VariableDeclarator,
           node.kind,

diff --git a/packages/eslint-plugin/src/rules/indent.ts b/packages/eslint-plugin/src/rules/indent.ts
@@ -175,6 +175,15 @@ export default util.createRule<Options, MessageIds>({
         }
       },
 
+      VariableDeclaration(node: TSESTree.VariableDeclaration) {
+        // https://github.com/typescript-eslint/typescript-eslint/issues/441
+        if (node.declarations.length === 0) {
+          return;
+        }
+
+        return rules.VariableDeclaration(node);
+      },
+
       TSAsExpression(node: TSESTree.TSAsExpression) {
         // transform it to a BinaryExpression
         return rules['BinaryExpression, LogicalExpression']({

diff --git a/packages/eslint-plugin/src/rules/prefer-for-of.ts b/packages/eslint-plugin/src/rules/prefer-for-of.ts
@@ -186,8 +186,11 @@ export default util.createRule({
           return;
         }
 
-        const [declarator] = node.init.declarations;
+        const declarator = node.init.declarations[0] as
+          | TSESTree.VariableDeclarator
+          | undefined;
         if (
+          !declarator ||
           !isZeroInitialized(declarator) ||
           declarator.id.type !== AST_NODE_TYPES.Identifier
         ) {

diff --git a/packages/eslint-plugin/tests/rules/indent/indent.test.ts b/packages/eslint-plugin/tests/rules/indent/indent.test.ts
@@ -768,6 +768,8 @@ const div: JQuery<HTMLElement> = $('<div>')
             `,
       options: [2, { VariableDeclarator: { const: 3 } }],
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/441
+    `const;`,
   ],
   invalid: [
     ...individualNodeTests.invalid,

diff --git a/packages/typescript-estree/src/ts-estree/ts-estree.ts b/packages/typescript-estree/src/ts-estree/ts-estree.ts
@@ -1387,6 +1387,7 @@ export interface UnaryExpression extends UnaryExpressionBase {
 
 export interface VariableDeclaration extends BaseNode {
   type: AST_NODE_TYPES.VariableDeclaration;
+  // NOTE - this is not guaranteed to have any elements in it. i.e. `const;`
   declarations: VariableDeclarator[];
   kind: 'let' | 'const' | 'var';
   declare?: boolean;