fix(eslint-plugin): [no-throw-literal] support type assertions (#2354)

typescript-eslint · Aug 6, 2020 · 470174a · 470174a
1 parent 522277d
commit 470174a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-throw-literal.ts b/packages/eslint-plugin/src/rules/no-throw-literal.ts
@@ -66,7 +66,8 @@ export default util.createRule({
         case AST_NODE_TYPES.Identifier:
         case AST_NODE_TYPES.CallExpression:
         case AST_NODE_TYPES.NewExpression:
-        case AST_NODE_TYPES.MemberExpression: {
+        case AST_NODE_TYPES.MemberExpression:
+        case AST_NODE_TYPES.TSAsExpression: {
           const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node);
           return checker.getTypeAtLocation(tsNode);
         }

diff --git a/packages/eslint-plugin/tests/rules/no-throw-literal.test.ts b/packages/eslint-plugin/tests/rules/no-throw-literal.test.ts
@@ -101,14 +101,17 @@ function foo() {
   throw Object.assign(new Error('message'), { foo: 'bar' });
 }
     `,
-    {
-      code: `
+    `
 const foo: Error | SyntaxError = bar();
 function bar() {
   throw foo;
 }
-      `,
-    },
+    `,
+    `
+declare const foo: Error | string;
+throw foo as Error;
+    `,
+    'throw new Error() as Error;',
   ],
   invalid: [
     {
@@ -390,5 +393,12 @@ function bar() {
         },
       ],
     },
+    {
+      code: `
+declare const foo: Error | string;
+throw foo as string;
+      `,
+      errors: [{ messageId: 'object' }],
+    },
   ],
 });