fix(eslint-plugin): [naming-convention] handle empty array-pattern (#…

…1450)
typescript-eslint · Jan 14, 2020 · 4726605 · 4726605
1 parent b5ef704
commit 4726605
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/naming-convention.ts b/packages/eslint-plugin/src/rules/naming-convention.ts
@@ -688,7 +688,9 @@ function getIdentifiersFromPattern(
 
     case AST_NODE_TYPES.ArrayPattern:
       pattern.elements.forEach(element => {
-        getIdentifiersFromPattern(element, identifiers);
+        if (element !== null) {
+          getIdentifiersFromPattern(element, identifiers);
+        }
       });
       break;
 

diff --git a/packages/eslint-plugin/tests/rules/naming-convention.test.ts b/packages/eslint-plugin/tests/rules/naming-convention.test.ts
@@ -684,6 +684,18 @@ ruleTester.run('naming-convention', rule, {
         },
       ],
     },
+    {
+      code: `
+        const match = 'test'.match(/test/);
+        const [, key, value] = match;
+      `,
+      options: [
+        {
+          selector: 'default',
+          format: ['camelCase'],
+        },
+      ],
+    },
   ],
   invalid: [
     ...createInvalidTestCases(cases),