From 47266053d311e867fb962f2dfaefab684c72a69e Mon Sep 17 00:00:00 2001 From: Jonathan Delgado Date: Mon, 13 Jan 2020 19:45:48 -0800 Subject: [PATCH] fix(eslint-plugin): [naming-convention] handle empty array-pattern (#1450) --- .../eslint-plugin/src/rules/naming-convention.ts | 4 +++- .../tests/rules/naming-convention.test.ts | 12 ++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin/src/rules/naming-convention.ts b/packages/eslint-plugin/src/rules/naming-convention.ts index 50acf190d04..aa66caee0f9 100644 --- a/packages/eslint-plugin/src/rules/naming-convention.ts +++ b/packages/eslint-plugin/src/rules/naming-convention.ts @@ -688,7 +688,9 @@ function getIdentifiersFromPattern( case AST_NODE_TYPES.ArrayPattern: pattern.elements.forEach(element => { - getIdentifiersFromPattern(element, identifiers); + if (element !== null) { + getIdentifiersFromPattern(element, identifiers); + } }); break; diff --git a/packages/eslint-plugin/tests/rules/naming-convention.test.ts b/packages/eslint-plugin/tests/rules/naming-convention.test.ts index de4625fbeb2..04bd8503554 100644 --- a/packages/eslint-plugin/tests/rules/naming-convention.test.ts +++ b/packages/eslint-plugin/tests/rules/naming-convention.test.ts @@ -684,6 +684,18 @@ ruleTester.run('naming-convention', rule, { }, ], }, + { + code: ` + const match = 'test'.match(/test/); + const [, key, value] = match; + `, + options: [ + { + selector: 'default', + format: ['camelCase'], + }, + ], + }, ], invalid: [ ...createInvalidTestCases(cases),