fix(eslint-plugin): [no-unsafe-call] allow import expressions (#1800)

typescript-eslint · Mar 26, 2020 · 4fa7107 · 4fa7107
1 parent b1b8284
commit 4fa7107
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-call.ts b/packages/eslint-plugin/src/rules/no-unsafe-call.ts
@@ -41,10 +41,10 @@ export default util.createRule<[], MessageIds>({
     }
 
     return {
-      'CallExpression, OptionalCallExpression'(
-        node: TSESTree.CallExpression | TSESTree.OptionalCallExpression,
+      ':matches(CallExpression, OptionalCallExpression) > :not(Import)'(
+        node: Exclude<TSESTree.LeftHandSideExpression, TSESTree.Import>,
       ): void {
-        checkCall(node.callee, node.callee, 'unsafeCall');
+        checkCall(node, node, 'unsafeCall');
       },
       NewExpression(node): void {
         checkCall(node.callee, node, 'unsafeNew');

diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts
@@ -20,6 +20,7 @@ ruleTester.run('no-unsafe-call', rule, {
     'function foo(x: { a?: () => void }) { x.a?.() }',
     'new Map()',
     'String.raw`foo`',
+    'const x = import("./foo");',
   ],
   invalid: [
     ...batchedSingleLineTests({