fix(eslint-plugin): [no-useless-constructor] handle bodyless construc…

…tor (#685)
typescript-eslint · Jul 25, 2019 · 55e788c · 55e788c
1 parent 92e98de
commit 55e788c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-useless-constructor.ts b/packages/eslint-plugin/src/rules/no-useless-constructor.ts
@@ -63,6 +63,7 @@ export default util.createRule<Options, MessageIds>({
         if (
           node.value &&
           node.value.type === AST_NODE_TYPES.FunctionExpression &&
+          node.value.body &&
           checkAccessibility(node) &&
           checkParams(node)
         ) {

diff --git a/packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts b/packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
@@ -50,6 +50,8 @@ ruleTester.run('no-useless-constructor', rule, {
     'class A extends B { private constructor(foo, bar) { super(bar); } }',
     'class A extends B { public constructor(foo){ super(foo); } }',
     'class A extends B { public constructor(foo){} }',
+    // type definition / overload
+    'class A { constructor(foo); }',
   ],
   invalid: [
     {