fix(eslint-plugin): [no-type-alias] handle readonly types in aliases (#…

…1990)
typescript-eslint · May 11, 2020 · 56d9870 · 56d9870
1 parent 51ca404
commit 56d9870
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/no-type-alias.ts b/packages/eslint-plugin/src/rules/no-type-alias.ts
@@ -262,7 +262,11 @@ export default util.createRule<Options, MessageIds>({
       } else if (
         // eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
         type.node.type.endsWith('Keyword') ||
-        aliasTypes.has(type.node.type)
+        aliasTypes.has(type.node.type) ||
+        (type.node.type === AST_NODE_TYPES.TSTypeOperator &&
+          type.node.operator === 'readonly' &&
+          type.node.typeAnnotation &&
+          aliasTypes.has(type.node.typeAnnotation.type))
       ) {
         // alias / keyword
         checkAndReport(allowAliases!, isTopLevel, type, 'Aliases');

diff --git a/packages/eslint-plugin/tests/rules/no-type-alias.test.ts b/packages/eslint-plugin/tests/rules/no-type-alias.test.ts
@@ -213,6 +213,10 @@ type Foo = Bar & string;
       code: 'type Foo = string | string[];',
       options: [{ allowAliases: 'in-unions-and-intersections' }],
     },
+    {
+      code: 'type Foo = string | readonly string[];',
+      options: [{ allowAliases: 'in-unions-and-intersections' }],
+    },
     {
       code: 'type Foo = string | string[];',
       options: [{ allowAliases: 'in-unions' }],