fix(eslint-plugin): [naming-convention] support unicode in regex (#2241)

typescript-eslint · Jun 24, 2020 · 5fdd21a · 5fdd21a
1 parent a2202c7
commit 5fdd21a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/eslint-plugin/src/rules/naming-convention.ts b/packages/eslint-plugin/src/rules/naming-convention.ts
@@ -1213,7 +1213,7 @@ function normalizeOption(option: Selector): NormalizedSelector {
     format: option.format ? option.format.map(f => PredefinedFormats[f]) : null,
     custom: option.custom
       ? {
-          regex: new RegExp(option.custom.regex),
+          regex: new RegExp(option.custom.regex, 'u'),
           match: option.custom.match,
         }
       : null,
@@ -1236,9 +1236,9 @@ function normalizeOption(option: Selector): NormalizedSelector {
     filter:
       option.filter !== undefined
         ? typeof option.filter === 'string'
-          ? { regex: new RegExp(option.filter), match: true }
+          ? { regex: new RegExp(option.filter, 'u'), match: true }
           : {
-              regex: new RegExp(option.filter.regex),
+              regex: new RegExp(option.filter.regex, 'u'),
               match: option.filter.match,
             }
         : null,

diff --git a/packages/eslint-plugin/tests/rules/naming-convention.test.ts b/packages/eslint-plugin/tests/rules/naming-convention.test.ts
@@ -963,7 +963,7 @@ ruleTester.run('naming-convention', rule, {
           data: {
             type: 'Variable',
             name: 'unused_foo',
-            regex: '/^unused_\\w/',
+            regex: '/^unused_\\w/u',
             regexMatch: 'not match',
           },
         },
@@ -973,7 +973,7 @@ ruleTester.run('naming-convention', rule, {
           data: {
             type: 'Variable',
             name: '_unused_foo',
-            regex: '/^unused_\\w/',
+            regex: '/^unused_\\w/u',
             regexMatch: 'not match',
           },
         },
@@ -983,7 +983,7 @@ ruleTester.run('naming-convention', rule, {
           data: {
             type: 'Interface',
             name: 'IFoo',
-            regex: '/^I[A-Z]/',
+            regex: '/^I[A-Z]/u',
             regexMatch: 'not match',
           },
         },
@@ -993,7 +993,7 @@ ruleTester.run('naming-convention', rule, {
           data: {
             type: 'Class',
             name: 'IBar',
-            regex: '/^I[A-Z]/',
+            regex: '/^I[A-Z]/u',
             regexMatch: 'not match',
           },
         },
@@ -1003,7 +1003,7 @@ ruleTester.run('naming-convention', rule, {
           data: {
             type: 'Function',
             name: 'fooBar',
-            regex: '/function/',
+            regex: '/function/u',
             regexMatch: 'match',
           },
         },