fix(eslint-plugin): [no-duplicate-imports] remove unnecessary type ch…

…ecking for `node.source` (#4196)
typescript-eslint · Nov 23, 2021 · 637722a · 637722a
1 parent 7821e4c
commit 637722a
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-duplicate-imports.ts b/packages/eslint-plugin/src/rules/no-duplicate-imports.ts
@@ -54,24 +54,14 @@ export default util.createRule<Options, MessageIds>({
       });
     }
 
-    function isStringLiteral(
-      node: TSESTree.Node | null,
-    ): node is TSESTree.StringLiteral {
-      return (
-        !!node &&
-        node.type === AST_NODE_TYPES.Literal &&
-        typeof node.value === 'string'
-      );
-    }
-
     function isAllMemberImport(node: TSESTree.ImportDeclaration): boolean {
       return node.specifiers.every(
         specifier => specifier.type === AST_NODE_TYPES.ImportSpecifier,
       );
     }
 
     function checkTypeImport(node: TSESTree.ImportDeclaration): void {
-      if (isStringLiteral(node.source)) {
+      if (node.source) {
         const value = node.source.value;
         const isMemberImport = isAllMemberImport(node);
         if (
@@ -96,7 +86,7 @@ export default util.createRule<Options, MessageIds>({
     function checkTypeExport(
       node: TSESTree.ExportNamedDeclaration | TSESTree.ExportAllDeclaration,
     ): void {
-      if (isStringLiteral(node.source)) {
+      if (node.source) {
         const value = node.source.value;
         if (typeExports.has(value)) {
           report('exportType', node, value);