From 637722a77667f6ed1e0cf1f0e752d61622ae8546 Mon Sep 17 00:00:00 2001 From: Sosuke Suzuki Date: Wed, 24 Nov 2021 08:39:28 +0900 Subject: [PATCH] fix(eslint-plugin): [no-duplicate-imports] remove unnecessary type checking for `node.source` (#4196) --- .../src/rules/no-duplicate-imports.ts | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/packages/eslint-plugin/src/rules/no-duplicate-imports.ts b/packages/eslint-plugin/src/rules/no-duplicate-imports.ts index b2ded1a2ea7..f270e7600d1 100644 --- a/packages/eslint-plugin/src/rules/no-duplicate-imports.ts +++ b/packages/eslint-plugin/src/rules/no-duplicate-imports.ts @@ -54,16 +54,6 @@ export default util.createRule({ }); } - function isStringLiteral( - node: TSESTree.Node | null, - ): node is TSESTree.StringLiteral { - return ( - !!node && - node.type === AST_NODE_TYPES.Literal && - typeof node.value === 'string' - ); - } - function isAllMemberImport(node: TSESTree.ImportDeclaration): boolean { return node.specifiers.every( specifier => specifier.type === AST_NODE_TYPES.ImportSpecifier, @@ -71,7 +61,7 @@ export default util.createRule({ } function checkTypeImport(node: TSESTree.ImportDeclaration): void { - if (isStringLiteral(node.source)) { + if (node.source) { const value = node.source.value; const isMemberImport = isAllMemberImport(node); if ( @@ -96,7 +86,7 @@ export default util.createRule({ function checkTypeExport( node: TSESTree.ExportNamedDeclaration | TSESTree.ExportAllDeclaration, ): void { - if (isStringLiteral(node.source)) { + if (node.source) { const value = node.source.value; if (typeExports.has(value)) { report('exportType', node, value);