fix(eslint-plugin): [no-explicit-any] error with ignoreRestArgs (#1796)

typescript-eslint · Mar 26, 2020 · 638d84d · 638d84d
1 parent 4fa7107
commit 638d84d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-explicit-any.ts b/packages/eslint-plugin/src/rules/no-explicit-any.ts
@@ -131,9 +131,7 @@ export default util.createRule<Options, MessageIds>({
      */
     function isGreatGrandparentRestElement(node: TSESTree.Node): boolean {
       return (
-        typeof node.parent !== 'undefined' &&
-        typeof node.parent.parent !== 'undefined' &&
-        typeof node.parent.parent.parent !== 'undefined' &&
+        node?.parent?.parent?.parent != null &&
         isNodeRestElementInFunction(node.parent.parent.parent)
       );
     }
@@ -146,11 +144,8 @@ export default util.createRule<Options, MessageIds>({
      */
     function isGreatGreatGrandparentRestElement(node: TSESTree.Node): boolean {
       return (
-        typeof node.parent !== 'undefined' &&
-        typeof node.parent.parent !== 'undefined' &&
+        node.parent?.parent?.parent?.parent != null &&
         isNodeValidTSType(node.parent.parent) &&
-        typeof node.parent.parent.parent !== 'undefined' &&
-        typeof node.parent.parent.parent.parent !== 'undefined' &&
         isNodeRestElementInFunction(node.parent.parent.parent.parent)
       );
     }

diff --git a/packages/eslint-plugin/tests/rules/no-explicit-any.test.ts b/packages/eslint-plugin/tests/rules/no-explicit-any.test.ts
@@ -925,6 +925,17 @@ const test = <T extends Partial<never>>() => {};
         },
       ],
     },
+    {
+      code: `type Any = any;`,
+      options: [{ ignoreRestArgs: true }],
+      errors: [
+        {
+          messageId: 'unexpectedAny',
+          line: 1,
+          column: 12,
+        },
+      ],
+    },
     {
       code: `function foo5(...args: any) {}`,
       options: [{ ignoreRestArgs: true }],