fix(eslint-plugin): explicit-function-return-type: ensure class arrow…

… methods are validated (#377) Fixes #348
typescript-eslint · Mar 27, 2019 · 643a223 · 643a223
1 parent 6f5c0fa
commit 643a223
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/explicit-function-return-type.ts b/packages/eslint-plugin/src/rules/explicit-function-return-type.ts
@@ -114,6 +114,7 @@ export default util.createRule<Options, MessageIds>({
     ): void {
       if (
         options.allowExpressions &&
+        node.type !== AST_NODE_TYPES.ArrowFunctionExpression &&
         node.parent &&
         node.parent.type !== AST_NODE_TYPES.VariableDeclarator &&
         node.parent.type !== AST_NODE_TYPES.MethodDefinition

diff --git a/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts b/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts
@@ -41,6 +41,7 @@ class Test {
   method(): void {
     return;
   }
+  arrow = (): string => 'arrow';
 }
             `,
     },
@@ -171,6 +172,7 @@ class Test {
   method() {
     return;
   }
+  arrow = () => 'arrow';
 }
             `,
       errors: [
@@ -184,6 +186,11 @@ class Test {
           line: 8,
           column: 9,
         },
+        {
+          messageId: 'missingReturnType',
+          line: 11,
+          column: 11,
+        },
       ],
     },
     {