From 71c93706e55f5f92a1285102b93c6ab1950c6df4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= Date: Sat, 28 Aug 2021 23:57:54 +0200 Subject: [PATCH] feat: remove `meta.docs.category` from rules (#3800) --- .../src/rules/no-poorly-typed-ts-props.ts | 1 - .../src/rules/no-typescript-default-import.ts | 1 - .../src/rules/no-typescript-estree-import.ts | 1 - .../src/rules/plugin-test-formatting.ts | 1 - .../src/rules/prefer-ast-types-enum.ts | 1 - .../eslint-plugin-tslint/src/rules/config.ts | 2 -- .../src/rules/adjacent-overload-signatures.ts | 1 - .../eslint-plugin/src/rules/array-type.ts | 1 - .../eslint-plugin/src/rules/await-thenable.ts | 1 - .../eslint-plugin/src/rules/ban-ts-comment.ts | 1 - .../src/rules/ban-tslint-comment.ts | 1 - packages/eslint-plugin/src/rules/ban-types.ts | 1 - .../eslint-plugin/src/rules/brace-style.ts | 1 - .../src/rules/class-literal-property-style.ts | 1 - .../eslint-plugin/src/rules/comma-dangle.ts | 1 - .../eslint-plugin/src/rules/comma-spacing.ts | 1 - .../rules/consistent-indexed-object-style.ts | 1 - .../src/rules/consistent-type-assertions.ts | 1 - .../src/rules/consistent-type-definitions.ts | 1 - .../src/rules/consistent-type-imports.ts | 1 - .../src/rules/default-param-last.ts | 1 - .../eslint-plugin/src/rules/dot-notation.ts | 1 - .../rules/explicit-function-return-type.ts | 1 - .../rules/explicit-member-accessibility.ts | 1 - .../rules/explicit-module-boundary-types.ts | 1 - .../src/rules/func-call-spacing.ts | 1 - .../src/rules/indent-new-do-not-use/index.ts | 1 - packages/eslint-plugin/src/rules/indent.ts | 1 - .../src/rules/init-declarations.ts | 1 - .../src/rules/keyword-spacing.ts | 1 - .../src/rules/lines-between-class-members.ts | 1 - .../src/rules/member-delimiter-style.ts | 1 - .../src/rules/member-ordering.ts | 1 - .../src/rules/method-signature-style.ts | 1 - .../src/rules/naming-convention.ts | 1 - .../src/rules/no-array-constructor.ts | 1 - .../src/rules/no-base-to-string.ts | 1 - .../rules/no-confusing-non-null-assertion.ts | 1 - .../src/rules/no-confusing-void-expression.ts | 1 - .../src/rules/no-dupe-class-members.ts | 1 - .../src/rules/no-duplicate-imports.ts | 1 - .../src/rules/no-dynamic-delete.ts | 1 - .../src/rules/no-empty-function.ts | 1 - .../src/rules/no-empty-interface.ts | 1 - .../src/rules/no-explicit-any.ts | 1 - .../src/rules/no-extra-non-null-assertion.ts | 1 - .../src/rules/no-extra-parens.ts | 1 - .../eslint-plugin/src/rules/no-extra-semi.ts | 1 - .../src/rules/no-extraneous-class.ts | 1 - .../src/rules/no-floating-promises.ts | 1 - .../src/rules/no-for-in-array.ts | 1 - .../src/rules/no-implicit-any-catch.ts | 1 - .../src/rules/no-implied-eval.ts | 1 - .../src/rules/no-inferrable-types.ts | 1 - .../src/rules/no-invalid-this.ts | 1 - .../src/rules/no-invalid-void-type.ts | 1 - .../eslint-plugin/src/rules/no-loop-func.ts | 1 - .../src/rules/no-loss-of-precision.ts | 1 - .../src/rules/no-magic-numbers.ts | 1 - .../eslint-plugin/src/rules/no-misused-new.ts | 1 - .../src/rules/no-misused-promises.ts | 1 - .../eslint-plugin/src/rules/no-namespace.ts | 1 - .../no-non-null-asserted-optional-chain.ts | 1 - .../src/rules/no-non-null-assertion.ts | 1 - .../src/rules/no-parameter-properties.ts | 1 - .../eslint-plugin/src/rules/no-redeclare.ts | 1 - .../src/rules/no-require-imports.ts | 1 - packages/eslint-plugin/src/rules/no-shadow.ts | 1 - .../eslint-plugin/src/rules/no-this-alias.ts | 1 - .../src/rules/no-throw-literal.ts | 1 - .../eslint-plugin/src/rules/no-type-alias.ts | 1 - .../no-unnecessary-boolean-literal-compare.ts | 1 - .../src/rules/no-unnecessary-condition.ts | 1 - .../src/rules/no-unnecessary-qualifier.ts | 1 - .../rules/no-unnecessary-type-arguments.ts | 1 - .../rules/no-unnecessary-type-assertion.ts | 1 - .../rules/no-unnecessary-type-constraint.ts | 1 - .../src/rules/no-unsafe-argument.ts | 1 - .../src/rules/no-unsafe-assignment.ts | 1 - .../eslint-plugin/src/rules/no-unsafe-call.ts | 1 - .../src/rules/no-unsafe-member-access.ts | 1 - .../src/rules/no-unsafe-return.ts | 1 - .../src/rules/no-unused-expressions.ts | 1 - .../eslint-plugin/src/rules/no-unused-vars.ts | 1 - .../src/rules/no-use-before-define.ts | 1 - .../src/rules/no-useless-constructor.ts | 1 - .../src/rules/no-var-requires.ts | 1 - .../non-nullable-type-assertion-style.ts | 1 - .../src/rules/object-curly-spacing.ts | 1 - .../src/rules/prefer-as-const.ts | 1 - .../src/rules/prefer-enum-initializers.ts | 1 - .../eslint-plugin/src/rules/prefer-for-of.ts | 1 - .../src/rules/prefer-function-type.ts | 1 - .../src/rules/prefer-includes.ts | 1 - .../src/rules/prefer-literal-enum-member.ts | 1 - .../src/rules/prefer-namespace-keyword.ts | 1 - .../src/rules/prefer-nullish-coalescing.ts | 1 - .../src/rules/prefer-optional-chain.ts | 1 - .../rules/prefer-readonly-parameter-types.ts | 1 - .../src/rules/prefer-readonly.ts | 1 - .../src/rules/prefer-reduce-type-parameter.ts | 1 - .../src/rules/prefer-regexp-exec.ts | 1 - .../src/rules/prefer-return-this-type.ts | 1 - .../rules/prefer-string-starts-ends-with.ts | 1 - .../src/rules/prefer-ts-expect-error.ts | 1 - .../src/rules/promise-function-async.ts | 1 - packages/eslint-plugin/src/rules/quotes.ts | 1 - .../src/rules/require-array-sort-compare.ts | 1 - .../eslint-plugin/src/rules/require-await.ts | 1 - .../src/rules/restrict-plus-operands.ts | 1 - .../rules/restrict-template-expressions.ts | 1 - .../eslint-plugin/src/rules/return-await.ts | 1 - packages/eslint-plugin/src/rules/semi.ts | 1 - .../sort-type-union-intersection-members.ts | 1 - .../src/rules/space-before-function-paren.ts | 1 - .../src/rules/space-infix-ops.ts | 1 - .../src/rules/strict-boolean-expressions.ts | 1 - .../src/rules/switch-exhaustiveness-check.ts | 1 - .../src/rules/triple-slash-reference.ts | 1 - .../src/rules/type-annotation-spacing.ts | 1 - packages/eslint-plugin/src/rules/typedef.ts | 1 - .../eslint-plugin/src/rules/unbound-method.ts | 1 - .../src/rules/unified-signatures.ts | 1 - .../tests/util/getWrappingFixer.test.ts | 1 - .../experimental-utils/src/ts-eslint/Rule.ts | 20 ++++++------------- .../tests/eslint-utils/RuleCreator.test.ts | 2 -- yarn.lock | 6 +++--- 127 files changed, 9 insertions(+), 144 deletions(-) diff --git a/packages/eslint-plugin-internal/src/rules/no-poorly-typed-ts-props.ts b/packages/eslint-plugin-internal/src/rules/no-poorly-typed-ts-props.ts index 8ce331b4dad..f91068d9ffe 100644 --- a/packages/eslint-plugin-internal/src/rules/no-poorly-typed-ts-props.ts +++ b/packages/eslint-plugin-internal/src/rules/no-poorly-typed-ts-props.ts @@ -38,7 +38,6 @@ export default createRule({ docs: { description: "Enforces rules don't use TS API properties with known bad type definitions", - category: 'Possible Errors', recommended: 'error', suggestion: true, requiresTypeChecking: true, diff --git a/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts b/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts index ff4e35dc4f6..c8256131249 100644 --- a/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts +++ b/packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts @@ -22,7 +22,6 @@ export default createRule({ docs: { description: "Enforces that packages rules don't do `import ts from 'typescript';`", - category: 'Possible Errors', recommended: 'error', }, fixable: 'code', diff --git a/packages/eslint-plugin-internal/src/rules/no-typescript-estree-import.ts b/packages/eslint-plugin-internal/src/rules/no-typescript-estree-import.ts index b3c3a71c60d..3cc96a0f600 100644 --- a/packages/eslint-plugin-internal/src/rules/no-typescript-estree-import.ts +++ b/packages/eslint-plugin-internal/src/rules/no-typescript-estree-import.ts @@ -16,7 +16,6 @@ export default createRule({ type: 'problem', docs: { description: `Enforces that eslint-plugin rules don't require anything from ${TSESTREE_NAME} or ${TYPES_NAME}`, - category: 'Possible Errors', recommended: 'error', }, fixable: 'code', diff --git a/packages/eslint-plugin-internal/src/rules/plugin-test-formatting.ts b/packages/eslint-plugin-internal/src/rules/plugin-test-formatting.ts index ed03e0fe1ca..81fcb8c41cf 100644 --- a/packages/eslint-plugin-internal/src/rules/plugin-test-formatting.ts +++ b/packages/eslint-plugin-internal/src/rules/plugin-test-formatting.ts @@ -108,7 +108,6 @@ export default createRule({ type: 'problem', docs: { description: `Enforces that eslint-plugin test snippets are correctly formatted`, - category: 'Stylistic Issues', recommended: 'error', }, fixable: 'code', diff --git a/packages/eslint-plugin-internal/src/rules/prefer-ast-types-enum.ts b/packages/eslint-plugin-internal/src/rules/prefer-ast-types-enum.ts index c4a95695d96..e98d0904af5 100755 --- a/packages/eslint-plugin-internal/src/rules/prefer-ast-types-enum.ts +++ b/packages/eslint-plugin-internal/src/rules/prefer-ast-types-enum.ts @@ -15,7 +15,6 @@ export default createRule({ meta: { type: 'problem', docs: { - category: 'Best Practices', recommended: 'error', description: 'Ensures consistent usage of `AST_NODE_TYPES`, `AST_TOKEN_TYPES` and `DefinitionType` enums.', diff --git a/packages/eslint-plugin-tslint/src/rules/config.ts b/packages/eslint-plugin-tslint/src/rules/config.ts index 41326a8959c..e865d8cbcdc 100644 --- a/packages/eslint-plugin-tslint/src/rules/config.ts +++ b/packages/eslint-plugin-tslint/src/rules/config.ts @@ -63,8 +63,6 @@ export default createRule({ docs: { description: 'Wraps a TSLint configuration and lints the whole source using TSLint', - // @ts-expect-error - We know this is a one off special category for this plugin - category: 'TSLint', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/adjacent-overload-signatures.ts b/packages/eslint-plugin/src/rules/adjacent-overload-signatures.ts index 05f120b4cf2..273b6c6bfb9 100644 --- a/packages/eslint-plugin/src/rules/adjacent-overload-signatures.ts +++ b/packages/eslint-plugin/src/rules/adjacent-overload-signatures.ts @@ -21,7 +21,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Require that member overloads be consecutive', - category: 'Best Practices', recommended: 'error', }, schema: [], diff --git a/packages/eslint-plugin/src/rules/array-type.ts b/packages/eslint-plugin/src/rules/array-type.ts index 44de45f19de..da2bfdef518 100644 --- a/packages/eslint-plugin/src/rules/array-type.ts +++ b/packages/eslint-plugin/src/rules/array-type.ts @@ -92,7 +92,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Requires using either `T[]` or `Array` for arrays', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/await-thenable.ts b/packages/eslint-plugin/src/rules/await-thenable.ts index 9858bad8ba2..e1decc5ad3d 100644 --- a/packages/eslint-plugin/src/rules/await-thenable.ts +++ b/packages/eslint-plugin/src/rules/await-thenable.ts @@ -7,7 +7,6 @@ export default util.createRule({ meta: { docs: { description: 'Disallows awaiting a value that is not a Thenable', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/ban-ts-comment.ts b/packages/eslint-plugin/src/rules/ban-ts-comment.ts index 4bf17c25d95..a9e0caf0fe4 100644 --- a/packages/eslint-plugin/src/rules/ban-ts-comment.ts +++ b/packages/eslint-plugin/src/rules/ban-ts-comment.ts @@ -22,7 +22,6 @@ export default util.createRule<[Options], MessageIds>({ docs: { description: 'Bans `@ts-` comments from being used or requires descriptions after directive', - category: 'Best Practices', recommended: 'error', }, messages: { diff --git a/packages/eslint-plugin/src/rules/ban-tslint-comment.ts b/packages/eslint-plugin/src/rules/ban-tslint-comment.ts index 37dfefd380e..14d32e72d88 100644 --- a/packages/eslint-plugin/src/rules/ban-tslint-comment.ts +++ b/packages/eslint-plugin/src/rules/ban-tslint-comment.ts @@ -20,7 +20,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Bans `// tslint:` comments from being used', - category: 'Stylistic Issues', recommended: false, }, messages: { diff --git a/packages/eslint-plugin/src/rules/ban-types.ts b/packages/eslint-plugin/src/rules/ban-types.ts index c9f03c89b96..32f05e9c120 100644 --- a/packages/eslint-plugin/src/rules/ban-types.ts +++ b/packages/eslint-plugin/src/rules/ban-types.ts @@ -124,7 +124,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Bans specific types from being used', - category: 'Best Practices', recommended: 'error', }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/brace-style.ts b/packages/eslint-plugin/src/rules/brace-style.ts index 8bd77aa12ff..6635303b386 100644 --- a/packages/eslint-plugin/src/rules/brace-style.ts +++ b/packages/eslint-plugin/src/rules/brace-style.ts @@ -18,7 +18,6 @@ export default createRule({ type: 'layout', docs: { description: 'Enforce consistent brace style for blocks', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/class-literal-property-style.ts b/packages/eslint-plugin/src/rules/class-literal-property-style.ts index 0a257427ec1..dd3878e77a2 100644 --- a/packages/eslint-plugin/src/rules/class-literal-property-style.ts +++ b/packages/eslint-plugin/src/rules/class-literal-property-style.ts @@ -44,7 +44,6 @@ export default util.createRule({ docs: { description: 'Ensures that literals on classes are exposed in a consistent style', - category: 'Best Practices', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/comma-dangle.ts b/packages/eslint-plugin/src/rules/comma-dangle.ts index 9c212cca47e..298a3e92639 100644 --- a/packages/eslint-plugin/src/rules/comma-dangle.ts +++ b/packages/eslint-plugin/src/rules/comma-dangle.ts @@ -45,7 +45,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Require or disallow trailing comma', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/comma-spacing.ts b/packages/eslint-plugin/src/rules/comma-spacing.ts index 019a82a2e76..c78322be8ea 100644 --- a/packages/eslint-plugin/src/rules/comma-spacing.ts +++ b/packages/eslint-plugin/src/rules/comma-spacing.ts @@ -23,7 +23,6 @@ export default createRule({ type: 'suggestion', docs: { description: 'Enforces consistent spacing before and after commas', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/consistent-indexed-object-style.ts b/packages/eslint-plugin/src/rules/consistent-indexed-object-style.ts index fcce191b2b5..29c5e534b4a 100644 --- a/packages/eslint-plugin/src/rules/consistent-indexed-object-style.ts +++ b/packages/eslint-plugin/src/rules/consistent-indexed-object-style.ts @@ -14,7 +14,6 @@ export default createRule({ type: 'suggestion', docs: { description: 'Enforce or disallow the use of the record type', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/consistent-type-assertions.ts b/packages/eslint-plugin/src/rules/consistent-type-assertions.ts index 3b431b80675..61738179066 100644 --- a/packages/eslint-plugin/src/rules/consistent-type-assertions.ts +++ b/packages/eslint-plugin/src/rules/consistent-type-assertions.ts @@ -25,7 +25,6 @@ export default util.createRule({ meta: { type: 'suggestion', docs: { - category: 'Best Practices', description: 'Enforces consistent usage of type assertions', recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/consistent-type-definitions.ts b/packages/eslint-plugin/src/rules/consistent-type-definitions.ts index 07d848db298..bacccf9143f 100644 --- a/packages/eslint-plugin/src/rules/consistent-type-definitions.ts +++ b/packages/eslint-plugin/src/rules/consistent-type-definitions.ts @@ -13,7 +13,6 @@ export default util.createRule({ docs: { description: 'Consistent with type definition either `interface` or `type`', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/consistent-type-imports.ts b/packages/eslint-plugin/src/rules/consistent-type-imports.ts index 34f264ff0c7..1bfb695f27b 100644 --- a/packages/eslint-plugin/src/rules/consistent-type-imports.ts +++ b/packages/eslint-plugin/src/rules/consistent-type-imports.ts @@ -56,7 +56,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Enforces consistent usage of type imports', - category: 'Stylistic Issues', recommended: false, }, messages: { diff --git a/packages/eslint-plugin/src/rules/default-param-last.ts b/packages/eslint-plugin/src/rules/default-param-last.ts index dea41116911..9673d852dd1 100644 --- a/packages/eslint-plugin/src/rules/default-param-last.ts +++ b/packages/eslint-plugin/src/rules/default-param-last.ts @@ -10,7 +10,6 @@ export default createRule({ type: 'suggestion', docs: { description: 'Enforce default parameters to be last', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/dot-notation.ts b/packages/eslint-plugin/src/rules/dot-notation.ts index 9d5284b4aa6..01db4680cbe 100644 --- a/packages/eslint-plugin/src/rules/dot-notation.ts +++ b/packages/eslint-plugin/src/rules/dot-notation.ts @@ -20,7 +20,6 @@ export default createRule({ type: 'suggestion', docs: { description: 'enforce dot notation whenever possible', - category: 'Best Practices', recommended: false, extendsBaseRule: true, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/explicit-function-return-type.ts b/packages/eslint-plugin/src/rules/explicit-function-return-type.ts index f0904f07744..e9a27b2b1fc 100644 --- a/packages/eslint-plugin/src/rules/explicit-function-return-type.ts +++ b/packages/eslint-plugin/src/rules/explicit-function-return-type.ts @@ -26,7 +26,6 @@ export default util.createRule({ docs: { description: 'Require explicit return types on functions and class methods', - category: 'Stylistic Issues', recommended: false, }, messages: { diff --git a/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts b/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts index ece09d8bc71..89671fa7567 100644 --- a/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts +++ b/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts @@ -36,7 +36,6 @@ export default util.createRule({ docs: { description: 'Require explicit accessibility modifiers on class properties and methods', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts b/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts index 33caf65f19b..67301afc440 100644 --- a/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts +++ b/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts @@ -37,7 +37,6 @@ export default util.createRule({ docs: { description: "Require explicit return and argument types on exported functions' and classes' public class methods", - category: 'Stylistic Issues', recommended: 'warn', }, messages: { diff --git a/packages/eslint-plugin/src/rules/func-call-spacing.ts b/packages/eslint-plugin/src/rules/func-call-spacing.ts index 08d72181eeb..254f8939660 100644 --- a/packages/eslint-plugin/src/rules/func-call-spacing.ts +++ b/packages/eslint-plugin/src/rules/func-call-spacing.ts @@ -19,7 +19,6 @@ export default util.createRule({ docs: { description: 'Require or disallow spacing between function identifiers and their invocations', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts b/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts index 57342313596..863e7d0889d 100644 --- a/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts +++ b/packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts @@ -257,7 +257,6 @@ export default createRule({ type: 'layout', docs: { description: 'Enforce consistent indentation.', - category: 'Stylistic Issues', recommended: false, }, fixable: 'whitespace', diff --git a/packages/eslint-plugin/src/rules/indent.ts b/packages/eslint-plugin/src/rules/indent.ts index 42b00617701..7835fd0e58d 100644 --- a/packages/eslint-plugin/src/rules/indent.ts +++ b/packages/eslint-plugin/src/rules/indent.ts @@ -91,7 +91,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Enforce consistent indentation', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, extendsBaseRule: true, diff --git a/packages/eslint-plugin/src/rules/init-declarations.ts b/packages/eslint-plugin/src/rules/init-declarations.ts index a75d6e031cd..3a97a2c8eda 100644 --- a/packages/eslint-plugin/src/rules/init-declarations.ts +++ b/packages/eslint-plugin/src/rules/init-declarations.ts @@ -21,7 +21,6 @@ export default createRule({ docs: { description: 'require or disallow initialization in variable declarations', - category: 'Variables', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/keyword-spacing.ts b/packages/eslint-plugin/src/rules/keyword-spacing.ts index 18c1c60bbb9..a5620fb7d53 100644 --- a/packages/eslint-plugin/src/rules/keyword-spacing.ts +++ b/packages/eslint-plugin/src/rules/keyword-spacing.ts @@ -13,7 +13,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Enforce consistent spacing before and after keywords', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/lines-between-class-members.ts b/packages/eslint-plugin/src/rules/lines-between-class-members.ts index 0e52e7b958c..95c2f811e8a 100644 --- a/packages/eslint-plugin/src/rules/lines-between-class-members.ts +++ b/packages/eslint-plugin/src/rules/lines-between-class-members.ts @@ -28,7 +28,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Require or disallow an empty line between class members', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/member-delimiter-style.ts b/packages/eslint-plugin/src/rules/member-delimiter-style.ts index de0a60f013c..5fa5a863a6f 100644 --- a/packages/eslint-plugin/src/rules/member-delimiter-style.ts +++ b/packages/eslint-plugin/src/rules/member-delimiter-style.ts @@ -120,7 +120,6 @@ export default util.createRule({ docs: { description: 'Require a specific member delimiter style for interfaces and type literals', - category: 'Stylistic Issues', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/member-ordering.ts b/packages/eslint-plugin/src/rules/member-ordering.ts index 34c922a3918..13a4fb65ae5 100644 --- a/packages/eslint-plugin/src/rules/member-ordering.ts +++ b/packages/eslint-plugin/src/rules/member-ordering.ts @@ -423,7 +423,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Require a consistent member declaration order', - category: 'Stylistic Issues', recommended: false, }, messages: { diff --git a/packages/eslint-plugin/src/rules/method-signature-style.ts b/packages/eslint-plugin/src/rules/method-signature-style.ts index 4775a1fec71..3e24263ab50 100644 --- a/packages/eslint-plugin/src/rules/method-signature-style.ts +++ b/packages/eslint-plugin/src/rules/method-signature-style.ts @@ -13,7 +13,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Enforces using a particular method signature syntax.', - category: 'Best Practices', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/naming-convention.ts b/packages/eslint-plugin/src/rules/naming-convention.ts index 6b4b55309cf..91456c7ccb2 100644 --- a/packages/eslint-plugin/src/rules/naming-convention.ts +++ b/packages/eslint-plugin/src/rules/naming-convention.ts @@ -55,7 +55,6 @@ export default util.createRule({ name: 'naming-convention', meta: { docs: { - category: 'Variables', description: 'Enforces naming conventions for everything across a codebase', recommended: false, diff --git a/packages/eslint-plugin/src/rules/no-array-constructor.ts b/packages/eslint-plugin/src/rules/no-array-constructor.ts index f9d09439cbb..c0eac4a75af 100644 --- a/packages/eslint-plugin/src/rules/no-array-constructor.ts +++ b/packages/eslint-plugin/src/rules/no-array-constructor.ts @@ -10,7 +10,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow generic `Array` constructors', - category: 'Stylistic Issues', recommended: 'error', extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-base-to-string.ts b/packages/eslint-plugin/src/rules/no-base-to-string.ts index b1593c23d8b..11962363c64 100644 --- a/packages/eslint-plugin/src/rules/no-base-to-string.ts +++ b/packages/eslint-plugin/src/rules/no-base-to-string.ts @@ -25,7 +25,6 @@ export default util.createRule({ docs: { description: 'Requires that `.toString()` is only called on objects which provide useful information when stringified', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-confusing-non-null-assertion.ts b/packages/eslint-plugin/src/rules/no-confusing-non-null-assertion.ts index 281c2f9c463..f578c5d3a1d 100644 --- a/packages/eslint-plugin/src/rules/no-confusing-non-null-assertion.ts +++ b/packages/eslint-plugin/src/rules/no-confusing-non-null-assertion.ts @@ -13,7 +13,6 @@ export default util.createRule({ docs: { description: 'Disallow non-null assertion in locations that may be confusing', - category: 'Stylistic Issues', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts b/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts index 1ddb60bf73d..696c3d7af2d 100644 --- a/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts +++ b/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts @@ -30,7 +30,6 @@ export default util.createRule({ docs: { description: 'Requires expressions of type void to appear in statement position', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-dupe-class-members.ts b/packages/eslint-plugin/src/rules/no-dupe-class-members.ts index 0756e135fc9..dcc8b705038 100644 --- a/packages/eslint-plugin/src/rules/no-dupe-class-members.ts +++ b/packages/eslint-plugin/src/rules/no-dupe-class-members.ts @@ -16,7 +16,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow duplicate class members', - category: 'Possible Errors', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-duplicate-imports.ts b/packages/eslint-plugin/src/rules/no-duplicate-imports.ts index 773402e18d4..5445b50cec4 100644 --- a/packages/eslint-plugin/src/rules/no-duplicate-imports.ts +++ b/packages/eslint-plugin/src/rules/no-duplicate-imports.ts @@ -16,7 +16,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow duplicate imports', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-dynamic-delete.ts b/packages/eslint-plugin/src/rules/no-dynamic-delete.ts index 71ce7f2d91e..716590c66b6 100644 --- a/packages/eslint-plugin/src/rules/no-dynamic-delete.ts +++ b/packages/eslint-plugin/src/rules/no-dynamic-delete.ts @@ -10,7 +10,6 @@ export default util.createRule({ name: 'no-dynamic-delete', meta: { docs: { - category: 'Best Practices', description: 'Disallow the delete operator with computed key expressions', recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/no-empty-function.ts b/packages/eslint-plugin/src/rules/no-empty-function.ts index d34618e0354..06c04cb4eca 100644 --- a/packages/eslint-plugin/src/rules/no-empty-function.ts +++ b/packages/eslint-plugin/src/rules/no-empty-function.ts @@ -45,7 +45,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow empty functions', - category: 'Best Practices', recommended: 'error', extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-empty-interface.ts b/packages/eslint-plugin/src/rules/no-empty-interface.ts index d9c8c2477b8..ee472e70390 100644 --- a/packages/eslint-plugin/src/rules/no-empty-interface.ts +++ b/packages/eslint-plugin/src/rules/no-empty-interface.ts @@ -14,7 +14,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow the declaration of empty interfaces', - category: 'Best Practices', recommended: 'error', suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/no-explicit-any.ts b/packages/eslint-plugin/src/rules/no-explicit-any.ts index 71f05292327..a41d443e924 100644 --- a/packages/eslint-plugin/src/rules/no-explicit-any.ts +++ b/packages/eslint-plugin/src/rules/no-explicit-any.ts @@ -19,7 +19,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow usage of the `any` type', - category: 'Best Practices', recommended: 'warn', suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts b/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts index f507f37218f..1ea8970da2f 100644 --- a/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts +++ b/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts @@ -7,7 +7,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow extra non-null assertion', - category: 'Stylistic Issues', recommended: 'error', }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/no-extra-parens.ts b/packages/eslint-plugin/src/rules/no-extra-parens.ts index 0eeeedf2c2f..743c22596c1 100644 --- a/packages/eslint-plugin/src/rules/no-extra-parens.ts +++ b/packages/eslint-plugin/src/rules/no-extra-parens.ts @@ -20,7 +20,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Disallow unnecessary parentheses', - category: 'Possible Errors', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-extra-semi.ts b/packages/eslint-plugin/src/rules/no-extra-semi.ts index d8db4ba7904..5ed7372b08c 100644 --- a/packages/eslint-plugin/src/rules/no-extra-semi.ts +++ b/packages/eslint-plugin/src/rules/no-extra-semi.ts @@ -12,7 +12,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow unnecessary semicolons', - category: 'Possible Errors', recommended: 'error', extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-extraneous-class.ts b/packages/eslint-plugin/src/rules/no-extraneous-class.ts index e57ee5546a3..2686ab0f478 100644 --- a/packages/eslint-plugin/src/rules/no-extraneous-class.ts +++ b/packages/eslint-plugin/src/rules/no-extraneous-class.ts @@ -20,7 +20,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Forbids the use of classes as namespaces', - category: 'Best Practices', recommended: false, }, schema: [ diff --git a/packages/eslint-plugin/src/rules/no-floating-promises.ts b/packages/eslint-plugin/src/rules/no-floating-promises.ts index ae196cf5288..b1a88336e19 100644 --- a/packages/eslint-plugin/src/rules/no-floating-promises.ts +++ b/packages/eslint-plugin/src/rules/no-floating-promises.ts @@ -22,7 +22,6 @@ export default util.createRule({ meta: { docs: { description: 'Requires Promise-like values to be handled appropriately', - category: 'Best Practices', recommended: 'error', suggestion: true, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/no-for-in-array.ts b/packages/eslint-plugin/src/rules/no-for-in-array.ts index f89d2ffd08d..c382a11021c 100644 --- a/packages/eslint-plugin/src/rules/no-for-in-array.ts +++ b/packages/eslint-plugin/src/rules/no-for-in-array.ts @@ -6,7 +6,6 @@ export default util.createRule({ meta: { docs: { description: 'Disallow iterating over an array with a for-in loop', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-implicit-any-catch.ts b/packages/eslint-plugin/src/rules/no-implicit-any-catch.ts index 85cdd7fd8fc..f933336866b 100644 --- a/packages/eslint-plugin/src/rules/no-implicit-any-catch.ts +++ b/packages/eslint-plugin/src/rules/no-implicit-any-catch.ts @@ -20,7 +20,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow usage of the implicit `any` type in catch clauses', - category: 'Best Practices', recommended: false, suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/no-implied-eval.ts b/packages/eslint-plugin/src/rules/no-implied-eval.ts index 34b1c70b16d..91bf0d0d319 100644 --- a/packages/eslint-plugin/src/rules/no-implied-eval.ts +++ b/packages/eslint-plugin/src/rules/no-implied-eval.ts @@ -20,7 +20,6 @@ export default util.createRule({ meta: { docs: { description: 'Disallow the use of `eval()`-like methods', - category: 'Best Practices', recommended: 'error', extendsBaseRule: true, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/no-inferrable-types.ts b/packages/eslint-plugin/src/rules/no-inferrable-types.ts index 4edcf69c975..23d8616e934 100644 --- a/packages/eslint-plugin/src/rules/no-inferrable-types.ts +++ b/packages/eslint-plugin/src/rules/no-inferrable-types.ts @@ -20,7 +20,6 @@ export default util.createRule({ docs: { description: 'Disallows explicit type declarations for variables or parameters initialized to a number, string, or boolean', - category: 'Best Practices', recommended: 'error', }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/no-invalid-this.ts b/packages/eslint-plugin/src/rules/no-invalid-this.ts index eb21da3ff8b..9b8a4ac8d8a 100644 --- a/packages/eslint-plugin/src/rules/no-invalid-this.ts +++ b/packages/eslint-plugin/src/rules/no-invalid-this.ts @@ -21,7 +21,6 @@ export default createRule({ docs: { description: 'Disallow `this` keywords outside of classes or class-like objects', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-invalid-void-type.ts b/packages/eslint-plugin/src/rules/no-invalid-void-type.ts index 62c1aa679cf..5c7829cde6c 100644 --- a/packages/eslint-plugin/src/rules/no-invalid-void-type.ts +++ b/packages/eslint-plugin/src/rules/no-invalid-void-type.ts @@ -23,7 +23,6 @@ export default util.createRule<[Options], MessageIds>({ docs: { description: 'Disallows usage of `void` type outside of generic or return types', - category: 'Best Practices', recommended: false, }, messages: { diff --git a/packages/eslint-plugin/src/rules/no-loop-func.ts b/packages/eslint-plugin/src/rules/no-loop-func.ts index b3e57903dd1..4496dea91fc 100644 --- a/packages/eslint-plugin/src/rules/no-loop-func.ts +++ b/packages/eslint-plugin/src/rules/no-loop-func.ts @@ -18,7 +18,6 @@ export default util.createRule({ docs: { description: 'Disallow function declarations that contain unsafe references inside loop statements', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-loss-of-precision.ts b/packages/eslint-plugin/src/rules/no-loss-of-precision.ts index 3b53661a026..95503247475 100644 --- a/packages/eslint-plugin/src/rules/no-loss-of-precision.ts +++ b/packages/eslint-plugin/src/rules/no-loss-of-precision.ts @@ -15,7 +15,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow literal numbers that lose precision', - category: 'Possible Errors', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-magic-numbers.ts b/packages/eslint-plugin/src/rules/no-magic-numbers.ts index 8171815bb56..a434a06dcf9 100644 --- a/packages/eslint-plugin/src/rules/no-magic-numbers.ts +++ b/packages/eslint-plugin/src/rules/no-magic-numbers.ts @@ -20,7 +20,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow magic numbers', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-misused-new.ts b/packages/eslint-plugin/src/rules/no-misused-new.ts index d0331e19fa3..ae79c28a6f2 100644 --- a/packages/eslint-plugin/src/rules/no-misused-new.ts +++ b/packages/eslint-plugin/src/rules/no-misused-new.ts @@ -10,7 +10,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Enforce valid definition of `new` and `constructor`', - category: 'Best Practices', recommended: 'error', }, schema: [], diff --git a/packages/eslint-plugin/src/rules/no-misused-promises.ts b/packages/eslint-plugin/src/rules/no-misused-promises.ts index 58d4ac9f9c6..353b7d4a803 100644 --- a/packages/eslint-plugin/src/rules/no-misused-promises.ts +++ b/packages/eslint-plugin/src/rules/no-misused-promises.ts @@ -20,7 +20,6 @@ export default util.createRule({ meta: { docs: { description: 'Avoid using promises in places not designed to handle them', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-namespace.ts b/packages/eslint-plugin/src/rules/no-namespace.ts index f8cc05b1047..f7fb0ea1e32 100644 --- a/packages/eslint-plugin/src/rules/no-namespace.ts +++ b/packages/eslint-plugin/src/rules/no-namespace.ts @@ -19,7 +19,6 @@ export default util.createRule({ docs: { description: 'Disallow the use of custom TypeScript modules and namespaces', - category: 'Best Practices', recommended: 'error', }, messages: { diff --git a/packages/eslint-plugin/src/rules/no-non-null-asserted-optional-chain.ts b/packages/eslint-plugin/src/rules/no-non-null-asserted-optional-chain.ts index 1d9c8f4aabc..9fdba130b97 100644 --- a/packages/eslint-plugin/src/rules/no-non-null-asserted-optional-chain.ts +++ b/packages/eslint-plugin/src/rules/no-non-null-asserted-optional-chain.ts @@ -22,7 +22,6 @@ export default util.createRule({ docs: { description: 'Disallows using a non-null assertion after an optional chain expression', - category: 'Possible Errors', recommended: 'error', suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/no-non-null-assertion.ts b/packages/eslint-plugin/src/rules/no-non-null-assertion.ts index ceba7fefd15..cd9f0dbb255 100644 --- a/packages/eslint-plugin/src/rules/no-non-null-assertion.ts +++ b/packages/eslint-plugin/src/rules/no-non-null-assertion.ts @@ -13,7 +13,6 @@ export default util.createRule<[], MessageIds>({ docs: { description: 'Disallows non-null assertions using the `!` postfix operator', - category: 'Stylistic Issues', recommended: 'warn', suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/no-parameter-properties.ts b/packages/eslint-plugin/src/rules/no-parameter-properties.ts index 9b6bb31e654..613b839bbdf 100644 --- a/packages/eslint-plugin/src/rules/no-parameter-properties.ts +++ b/packages/eslint-plugin/src/rules/no-parameter-properties.ts @@ -26,7 +26,6 @@ export default util.createRule({ docs: { description: 'Disallow the use of parameter properties in class constructors', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/no-redeclare.ts b/packages/eslint-plugin/src/rules/no-redeclare.ts index ae4b2e9a3f5..914dd074d33 100644 --- a/packages/eslint-plugin/src/rules/no-redeclare.ts +++ b/packages/eslint-plugin/src/rules/no-redeclare.ts @@ -19,7 +19,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow variable redeclaration', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-require-imports.ts b/packages/eslint-plugin/src/rules/no-require-imports.ts index 9aa4b685dd2..49bd5f237b0 100644 --- a/packages/eslint-plugin/src/rules/no-require-imports.ts +++ b/packages/eslint-plugin/src/rules/no-require-imports.ts @@ -7,7 +7,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallows invocation of `require()`', - category: 'Best Practices', recommended: false, }, schema: [], diff --git a/packages/eslint-plugin/src/rules/no-shadow.ts b/packages/eslint-plugin/src/rules/no-shadow.ts index a49afd502cf..27c68930931 100644 --- a/packages/eslint-plugin/src/rules/no-shadow.ts +++ b/packages/eslint-plugin/src/rules/no-shadow.ts @@ -30,7 +30,6 @@ export default util.createRule({ docs: { description: 'Disallow variable declarations from shadowing variables declared in the outer scope', - category: 'Variables', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-this-alias.ts b/packages/eslint-plugin/src/rules/no-this-alias.ts index 8865fad2c3f..82ab9b22b0f 100644 --- a/packages/eslint-plugin/src/rules/no-this-alias.ts +++ b/packages/eslint-plugin/src/rules/no-this-alias.ts @@ -18,7 +18,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow aliasing `this`', - category: 'Best Practices', recommended: 'error', }, schema: [ diff --git a/packages/eslint-plugin/src/rules/no-throw-literal.ts b/packages/eslint-plugin/src/rules/no-throw-literal.ts index 92bf3b02a13..178f1f39f9c 100644 --- a/packages/eslint-plugin/src/rules/no-throw-literal.ts +++ b/packages/eslint-plugin/src/rules/no-throw-literal.ts @@ -11,7 +11,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow throwing literals as exceptions', - category: 'Best Practices', recommended: false, extendsBaseRule: true, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/no-type-alias.ts b/packages/eslint-plugin/src/rules/no-type-alias.ts index 4e16216ea72..347e36f0a42 100644 --- a/packages/eslint-plugin/src/rules/no-type-alias.ts +++ b/packages/eslint-plugin/src/rules/no-type-alias.ts @@ -47,7 +47,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow the use of type aliases', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, }, diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-boolean-literal-compare.ts b/packages/eslint-plugin/src/rules/no-unnecessary-boolean-literal-compare.ts index 55719d857da..8583e657f91 100644 --- a/packages/eslint-plugin/src/rules/no-unnecessary-boolean-literal-compare.ts +++ b/packages/eslint-plugin/src/rules/no-unnecessary-boolean-literal-compare.ts @@ -38,7 +38,6 @@ export default util.createRule({ docs: { description: 'Flags unnecessary equality comparisons against boolean literals', - category: 'Stylistic Issues', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts b/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts index caca4f8bedb..4e73c0623ad 100644 --- a/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts +++ b/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts @@ -90,7 +90,6 @@ export default createRule({ docs: { description: 'Prevents conditionals where the type is always truthy or always falsy', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts b/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts index 014b2c220e4..1f4652085bd 100644 --- a/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts +++ b/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts @@ -10,7 +10,6 @@ export default util.createRule({ name: 'no-unnecessary-qualifier', meta: { docs: { - category: 'Best Practices', description: 'Warns when a namespace qualifier is unnecessary', recommended: false, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-arguments.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-arguments.ts index 2df933084dc..9f7d718c2d9 100644 --- a/packages/eslint-plugin/src/rules/no-unnecessary-type-arguments.ts +++ b/packages/eslint-plugin/src/rules/no-unnecessary-type-arguments.ts @@ -22,7 +22,6 @@ export default util.createRule<[], MessageIds>({ docs: { description: 'Enforces that type arguments will not be used if not required', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts index d16f494fc4a..cd5bce1845d 100644 --- a/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts +++ b/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts @@ -25,7 +25,6 @@ export default util.createRule({ docs: { description: 'Warns if a type assertion does not change the type of an expression', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts index 6d5036c2d75..535cae96023 100644 --- a/packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts +++ b/packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts @@ -32,7 +32,6 @@ export default util.createRule({ name: 'no-unnecessary-type-constraint', meta: { docs: { - category: 'Best Practices', description: 'Disallows unnecessary constraints on generic types', recommended: false, suggestion: true, diff --git a/packages/eslint-plugin/src/rules/no-unsafe-argument.ts b/packages/eslint-plugin/src/rules/no-unsafe-argument.ts index 053485f9228..46ed36a0dc3 100644 --- a/packages/eslint-plugin/src/rules/no-unsafe-argument.ts +++ b/packages/eslint-plugin/src/rules/no-unsafe-argument.ts @@ -138,7 +138,6 @@ export default util.createRule<[], MessageIds>({ type: 'problem', docs: { description: 'Disallows calling a function with an any type value', - category: 'Possible Errors', // TODO - enable this with next breaking recommended: false, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/no-unsafe-assignment.ts b/packages/eslint-plugin/src/rules/no-unsafe-assignment.ts index ae900b14f0c..b14f43fe27f 100644 --- a/packages/eslint-plugin/src/rules/no-unsafe-assignment.ts +++ b/packages/eslint-plugin/src/rules/no-unsafe-assignment.ts @@ -22,7 +22,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallows assigning any to variables and properties', - category: 'Possible Errors', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unsafe-call.ts b/packages/eslint-plugin/src/rules/no-unsafe-call.ts index b08214d36c2..781908f9497 100644 --- a/packages/eslint-plugin/src/rules/no-unsafe-call.ts +++ b/packages/eslint-plugin/src/rules/no-unsafe-call.ts @@ -15,7 +15,6 @@ export default util.createRule<[], MessageIds>({ type: 'problem', docs: { description: 'Disallows calling an any type value', - category: 'Possible Errors', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts b/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts index 121e826053e..6e9555a5a3e 100644 --- a/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts +++ b/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts @@ -17,7 +17,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallows member access on any typed variables', - category: 'Possible Errors', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unsafe-return.ts b/packages/eslint-plugin/src/rules/no-unsafe-return.ts index d460dd04c9b..e226d526bca 100644 --- a/packages/eslint-plugin/src/rules/no-unsafe-return.ts +++ b/packages/eslint-plugin/src/rules/no-unsafe-return.ts @@ -12,7 +12,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallows returning any from a function', - category: 'Possible Errors', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unused-expressions.ts b/packages/eslint-plugin/src/rules/no-unused-expressions.ts index 527ba14e03c..4bef50b44a8 100644 --- a/packages/eslint-plugin/src/rules/no-unused-expressions.ts +++ b/packages/eslint-plugin/src/rules/no-unused-expressions.ts @@ -16,7 +16,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow unused expressions', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-unused-vars.ts b/packages/eslint-plugin/src/rules/no-unused-vars.ts index 2e6633afc57..bf9548ec888 100644 --- a/packages/eslint-plugin/src/rules/no-unused-vars.ts +++ b/packages/eslint-plugin/src/rules/no-unused-vars.ts @@ -37,7 +37,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow unused variables', - category: 'Variables', recommended: 'warn', extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-use-before-define.ts b/packages/eslint-plugin/src/rules/no-use-before-define.ts index ef39ec9a5b7..83cf552fda5 100644 --- a/packages/eslint-plugin/src/rules/no-use-before-define.ts +++ b/packages/eslint-plugin/src/rules/no-use-before-define.ts @@ -232,7 +232,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow the use of variables before they are defined', - category: 'Variables', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-useless-constructor.ts b/packages/eslint-plugin/src/rules/no-useless-constructor.ts index d1134bd09db..f656af26481 100644 --- a/packages/eslint-plugin/src/rules/no-useless-constructor.ts +++ b/packages/eslint-plugin/src/rules/no-useless-constructor.ts @@ -51,7 +51,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Disallow unnecessary constructors', - category: 'Best Practices', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/no-var-requires.ts b/packages/eslint-plugin/src/rules/no-var-requires.ts index d7ed1d16f7f..b599d4cb87a 100644 --- a/packages/eslint-plugin/src/rules/no-var-requires.ts +++ b/packages/eslint-plugin/src/rules/no-var-requires.ts @@ -14,7 +14,6 @@ export default util.createRule({ docs: { description: 'Disallows the use of require statements except in import statements', - category: 'Best Practices', recommended: 'error', }, messages: { diff --git a/packages/eslint-plugin/src/rules/non-nullable-type-assertion-style.ts b/packages/eslint-plugin/src/rules/non-nullable-type-assertion-style.ts index 647fbcddd4c..1577c3b9448 100644 --- a/packages/eslint-plugin/src/rules/non-nullable-type-assertion-style.ts +++ b/packages/eslint-plugin/src/rules/non-nullable-type-assertion-style.ts @@ -11,7 +11,6 @@ export default util.createRule({ name: 'non-nullable-type-assertion-style', meta: { docs: { - category: 'Best Practices', description: 'Prefers a non-null assertion over explicit type cast when possible', recommended: false, diff --git a/packages/eslint-plugin/src/rules/object-curly-spacing.ts b/packages/eslint-plugin/src/rules/object-curly-spacing.ts index 090bd8e1e95..5e93dff61a0 100644 --- a/packages/eslint-plugin/src/rules/object-curly-spacing.ts +++ b/packages/eslint-plugin/src/rules/object-curly-spacing.ts @@ -24,7 +24,6 @@ export default createRule({ ...baseRule.meta, docs: { description: 'Enforce consistent spacing inside braces', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-as-const.ts b/packages/eslint-plugin/src/rules/prefer-as-const.ts index aeaa6fcdd7a..93bcce50889 100644 --- a/packages/eslint-plugin/src/rules/prefer-as-const.ts +++ b/packages/eslint-plugin/src/rules/prefer-as-const.ts @@ -11,7 +11,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Prefer usage of `as const` over literal type', - category: 'Best Practices', recommended: 'error', suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-enum-initializers.ts b/packages/eslint-plugin/src/rules/prefer-enum-initializers.ts index 9f9d641ec41..5ad6dccd7cc 100644 --- a/packages/eslint-plugin/src/rules/prefer-enum-initializers.ts +++ b/packages/eslint-plugin/src/rules/prefer-enum-initializers.ts @@ -9,7 +9,6 @@ export default util.createRule<[], MessageIds>({ type: 'suggestion', docs: { description: 'Prefer initializing each enums member value', - category: 'Best Practices', recommended: false, suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-for-of.ts b/packages/eslint-plugin/src/rules/prefer-for-of.ts index 361ad5ec2cf..25043615f81 100644 --- a/packages/eslint-plugin/src/rules/prefer-for-of.ts +++ b/packages/eslint-plugin/src/rules/prefer-for-of.ts @@ -12,7 +12,6 @@ export default util.createRule({ docs: { description: 'Prefer a ‘for-of’ loop over a standard ‘for’ loop if the index is only used to access the array being iterated', - category: 'Stylistic Issues', recommended: false, }, messages: { diff --git a/packages/eslint-plugin/src/rules/prefer-function-type.ts b/packages/eslint-plugin/src/rules/prefer-function-type.ts index 761e8bc98eb..ceeafcd841c 100644 --- a/packages/eslint-plugin/src/rules/prefer-function-type.ts +++ b/packages/eslint-plugin/src/rules/prefer-function-type.ts @@ -17,7 +17,6 @@ export default util.createRule({ docs: { description: 'Use function types instead of interfaces with call signatures', - category: 'Best Practices', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/prefer-includes.ts b/packages/eslint-plugin/src/rules/prefer-includes.ts index 13a6021c806..f15a756abc4 100644 --- a/packages/eslint-plugin/src/rules/prefer-includes.ts +++ b/packages/eslint-plugin/src/rules/prefer-includes.ts @@ -20,7 +20,6 @@ export default createRule({ type: 'suggestion', docs: { description: 'Enforce `includes` method over `indexOf` method', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts b/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts index 77b6746a06b..8f10eb9be36 100644 --- a/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts +++ b/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts @@ -8,7 +8,6 @@ export default createRule({ docs: { description: 'Require that all enum members be literal values to prevent unintended enum member name shadow issues', - category: 'Best Practices', recommended: false, requiresTypeChecking: false, }, diff --git a/packages/eslint-plugin/src/rules/prefer-namespace-keyword.ts b/packages/eslint-plugin/src/rules/prefer-namespace-keyword.ts index 9137fe912aa..4af7c981253 100644 --- a/packages/eslint-plugin/src/rules/prefer-namespace-keyword.ts +++ b/packages/eslint-plugin/src/rules/prefer-namespace-keyword.ts @@ -11,7 +11,6 @@ export default util.createRule({ docs: { description: 'Require the use of the `namespace` keyword instead of the `module` keyword to declare custom TypeScript modules', - category: 'Best Practices', recommended: 'error', }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts b/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts index 4fe3d021f70..6975576edca 100644 --- a/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts +++ b/packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts @@ -21,7 +21,6 @@ export default util.createRule({ docs: { description: 'Enforce the usage of the nullish coalescing operator instead of logical chaining', - category: 'Best Practices', recommended: false, suggestion: true, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/prefer-optional-chain.ts b/packages/eslint-plugin/src/rules/prefer-optional-chain.ts index b1eff5e4ae7..84c2e15e397 100644 --- a/packages/eslint-plugin/src/rules/prefer-optional-chain.ts +++ b/packages/eslint-plugin/src/rules/prefer-optional-chain.ts @@ -37,7 +37,6 @@ export default util.createRule({ docs: { description: 'Prefer using concise optional chain expressions instead of chained logical ands', - category: 'Best Practices', recommended: false, suggestion: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-readonly-parameter-types.ts b/packages/eslint-plugin/src/rules/prefer-readonly-parameter-types.ts index fdf48395eae..478a15b66b7 100644 --- a/packages/eslint-plugin/src/rules/prefer-readonly-parameter-types.ts +++ b/packages/eslint-plugin/src/rules/prefer-readonly-parameter-types.ts @@ -19,7 +19,6 @@ export default util.createRule({ docs: { description: 'Requires that function parameters are typed as readonly to prevent accidental mutation of inputs', - category: 'Possible Errors', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-readonly.ts b/packages/eslint-plugin/src/rules/prefer-readonly.ts index 36c6c7ea81a..7b0fbfee3af 100644 --- a/packages/eslint-plugin/src/rules/prefer-readonly.ts +++ b/packages/eslint-plugin/src/rules/prefer-readonly.ts @@ -28,7 +28,6 @@ export default util.createRule({ docs: { description: "Requires that private members are marked as `readonly` if they're never modified outside of the constructor", - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-reduce-type-parameter.ts b/packages/eslint-plugin/src/rules/prefer-reduce-type-parameter.ts index 8656c8d2376..a797bfdf48f 100644 --- a/packages/eslint-plugin/src/rules/prefer-reduce-type-parameter.ts +++ b/packages/eslint-plugin/src/rules/prefer-reduce-type-parameter.ts @@ -30,7 +30,6 @@ export default util.createRule({ meta: { type: 'problem', docs: { - category: 'Best Practices', recommended: false, description: 'Prefer using type parameter when calling `Array#reduce` instead of casting', diff --git a/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts b/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts index bbb7d9aac74..93ac0cda640 100644 --- a/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts +++ b/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts @@ -29,7 +29,6 @@ export default createRule({ docs: { description: 'Enforce that `RegExp#exec` is used instead of `String#match` if no global flag is provided', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-return-this-type.ts b/packages/eslint-plugin/src/rules/prefer-return-this-type.ts index 9fcfcb04200..b6be29efc04 100644 --- a/packages/eslint-plugin/src/rules/prefer-return-this-type.ts +++ b/packages/eslint-plugin/src/rules/prefer-return-this-type.ts @@ -22,7 +22,6 @@ export default createRule({ docs: { description: 'Enforce that `this` is used when only `this` type is returned', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts b/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts index f4697b7c01d..c90bb0a1a74 100644 --- a/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts +++ b/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts @@ -27,7 +27,6 @@ export default createRule({ docs: { description: 'Enforce the use of `String#startsWith` and `String#endsWith` instead of other equivalent methods of checking substrings', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/prefer-ts-expect-error.ts b/packages/eslint-plugin/src/rules/prefer-ts-expect-error.ts index d696fc04573..15c070298cb 100644 --- a/packages/eslint-plugin/src/rules/prefer-ts-expect-error.ts +++ b/packages/eslint-plugin/src/rules/prefer-ts-expect-error.ts @@ -16,7 +16,6 @@ export default util.createRule<[], MessageIds>({ type: 'problem', docs: { description: 'Recommends using `@ts-expect-error` over `@ts-ignore`', - category: 'Best Practices', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/promise-function-async.ts b/packages/eslint-plugin/src/rules/promise-function-async.ts index 68b1d42567c..6b3f29b8d97 100644 --- a/packages/eslint-plugin/src/rules/promise-function-async.ts +++ b/packages/eslint-plugin/src/rules/promise-function-async.ts @@ -26,7 +26,6 @@ export default util.createRule({ docs: { description: 'Requires any function or method that returns a Promise to be marked async', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/quotes.ts b/packages/eslint-plugin/src/rules/quotes.ts index 699df89da15..e03556af63d 100644 --- a/packages/eslint-plugin/src/rules/quotes.ts +++ b/packages/eslint-plugin/src/rules/quotes.ts @@ -17,7 +17,6 @@ export default util.createRule({ docs: { description: 'Enforce the consistent use of either backticks, double, or single quotes', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/require-array-sort-compare.ts b/packages/eslint-plugin/src/rules/require-array-sort-compare.ts index 6e0c49f31a8..25476314d73 100644 --- a/packages/eslint-plugin/src/rules/require-array-sort-compare.ts +++ b/packages/eslint-plugin/src/rules/require-array-sort-compare.ts @@ -21,7 +21,6 @@ export default util.createRule({ docs: { description: 'Requires `Array#sort` calls to always provide a `compareFunction`', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/require-await.ts b/packages/eslint-plugin/src/rules/require-await.ts index 99c455cd0f6..a1e92e8f91d 100644 --- a/packages/eslint-plugin/src/rules/require-await.ts +++ b/packages/eslint-plugin/src/rules/require-await.ts @@ -25,7 +25,6 @@ export default util.createRule({ type: 'suggestion', docs: { description: 'Disallow async functions which have no `await` expression', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, extendsBaseRule: true, diff --git a/packages/eslint-plugin/src/rules/restrict-plus-operands.ts b/packages/eslint-plugin/src/rules/restrict-plus-operands.ts index 0f3b07e9fb2..659509f81ef 100644 --- a/packages/eslint-plugin/src/rules/restrict-plus-operands.ts +++ b/packages/eslint-plugin/src/rules/restrict-plus-operands.ts @@ -16,7 +16,6 @@ export default util.createRule({ docs: { description: 'When adding two variables, operands must both be of type number or of type string', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/restrict-template-expressions.ts b/packages/eslint-plugin/src/rules/restrict-template-expressions.ts index b20bd5c62bc..f39bc88cfe5 100644 --- a/packages/eslint-plugin/src/rules/restrict-template-expressions.ts +++ b/packages/eslint-plugin/src/rules/restrict-template-expressions.ts @@ -23,7 +23,6 @@ export default util.createRule({ type: 'problem', docs: { description: 'Enforce template literal expressions to be of string type', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/return-await.ts b/packages/eslint-plugin/src/rules/return-await.ts index 1375d3028e1..93b863757a0 100644 --- a/packages/eslint-plugin/src/rules/return-await.ts +++ b/packages/eslint-plugin/src/rules/return-await.ts @@ -22,7 +22,6 @@ export default util.createRule({ meta: { docs: { description: 'Enforces consistent returning of awaited values', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, extendsBaseRule: 'no-return-await', diff --git a/packages/eslint-plugin/src/rules/semi.ts b/packages/eslint-plugin/src/rules/semi.ts index c8829ab83e3..40e631482aa 100644 --- a/packages/eslint-plugin/src/rules/semi.ts +++ b/packages/eslint-plugin/src/rules/semi.ts @@ -17,7 +17,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Require or disallow semicolons instead of ASI', - category: 'Stylistic Issues', // too opinionated to be recommended recommended: false, extendsBaseRule: true, diff --git a/packages/eslint-plugin/src/rules/sort-type-union-intersection-members.ts b/packages/eslint-plugin/src/rules/sort-type-union-intersection-members.ts index e7f042162b8..3d14b55e9d7 100644 --- a/packages/eslint-plugin/src/rules/sort-type-union-intersection-members.ts +++ b/packages/eslint-plugin/src/rules/sort-type-union-intersection-members.ts @@ -108,7 +108,6 @@ export default util.createRule({ docs: { description: 'Enforces that members of a type union/intersection are sorted alphabetically', - category: 'Stylistic Issues', recommended: false, }, fixable: 'code', diff --git a/packages/eslint-plugin/src/rules/space-before-function-paren.ts b/packages/eslint-plugin/src/rules/space-before-function-paren.ts index e2ccfa5182d..b13af67163c 100644 --- a/packages/eslint-plugin/src/rules/space-before-function-paren.ts +++ b/packages/eslint-plugin/src/rules/space-before-function-paren.ts @@ -23,7 +23,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Enforces consistent spacing before function parenthesis', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/space-infix-ops.ts b/packages/eslint-plugin/src/rules/space-infix-ops.ts index eb92bd2f112..80294cd2671 100644 --- a/packages/eslint-plugin/src/rules/space-infix-ops.ts +++ b/packages/eslint-plugin/src/rules/space-infix-ops.ts @@ -19,7 +19,6 @@ export default util.createRule({ docs: { description: 'This rule is aimed at ensuring there are spaces around infix operators.', - category: 'Stylistic Issues', recommended: false, extendsBaseRule: true, }, diff --git a/packages/eslint-plugin/src/rules/strict-boolean-expressions.ts b/packages/eslint-plugin/src/rules/strict-boolean-expressions.ts index 1aca481e743..10b48b5e9b3 100644 --- a/packages/eslint-plugin/src/rules/strict-boolean-expressions.ts +++ b/packages/eslint-plugin/src/rules/strict-boolean-expressions.ts @@ -52,7 +52,6 @@ export default util.createRule({ hasSuggestions: true, docs: { description: 'Restricts the types allowed in boolean expressions', - category: 'Best Practices', recommended: false, requiresTypeChecking: true, }, diff --git a/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts b/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts index 65a70a86cc4..08f21e3364c 100644 --- a/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts +++ b/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts @@ -16,7 +16,6 @@ export default createRule({ type: 'suggestion', docs: { description: 'Exhaustiveness checking in switch with union type', - category: 'Best Practices', recommended: false, suggestion: true, requiresTypeChecking: true, diff --git a/packages/eslint-plugin/src/rules/triple-slash-reference.ts b/packages/eslint-plugin/src/rules/triple-slash-reference.ts index 525febe2be3..ba8bce5ae8a 100644 --- a/packages/eslint-plugin/src/rules/triple-slash-reference.ts +++ b/packages/eslint-plugin/src/rules/triple-slash-reference.ts @@ -21,7 +21,6 @@ export default util.createRule({ docs: { description: 'Sets preference level for triple slash directives versus ES6-style import declarations', - category: 'Best Practices', recommended: 'error', }, messages: { diff --git a/packages/eslint-plugin/src/rules/type-annotation-spacing.ts b/packages/eslint-plugin/src/rules/type-annotation-spacing.ts index 0cf3e34b8b8..d02b8777d5f 100644 --- a/packages/eslint-plugin/src/rules/type-annotation-spacing.ts +++ b/packages/eslint-plugin/src/rules/type-annotation-spacing.ts @@ -114,7 +114,6 @@ export default util.createRule({ type: 'layout', docs: { description: 'Require consistent spacing around type annotations', - category: 'Stylistic Issues', recommended: false, }, fixable: 'whitespace', diff --git a/packages/eslint-plugin/src/rules/typedef.ts b/packages/eslint-plugin/src/rules/typedef.ts index 76640104022..35655a9a803 100644 --- a/packages/eslint-plugin/src/rules/typedef.ts +++ b/packages/eslint-plugin/src/rules/typedef.ts @@ -24,7 +24,6 @@ export default util.createRule<[Options], MessageIds>({ meta: { docs: { description: 'Requires type annotations to exist', - category: 'Stylistic Issues', recommended: false, }, messages: { diff --git a/packages/eslint-plugin/src/rules/unbound-method.ts b/packages/eslint-plugin/src/rules/unbound-method.ts index ecf9e652819..15ddf8b8910 100644 --- a/packages/eslint-plugin/src/rules/unbound-method.ts +++ b/packages/eslint-plugin/src/rules/unbound-method.ts @@ -128,7 +128,6 @@ export default util.createRule({ name: 'unbound-method', meta: { docs: { - category: 'Best Practices', description: 'Enforces unbound methods are called with their expected scope', recommended: 'error', diff --git a/packages/eslint-plugin/src/rules/unified-signatures.ts b/packages/eslint-plugin/src/rules/unified-signatures.ts index dced203f175..7481dcd7031 100644 --- a/packages/eslint-plugin/src/rules/unified-signatures.ts +++ b/packages/eslint-plugin/src/rules/unified-signatures.ts @@ -57,7 +57,6 @@ export default util.createRule({ docs: { description: 'Warns for any two overloads that could be unified into one by using a union or an optional/rest parameter', - category: 'Variables', // too opinionated to be recommended recommended: false, }, diff --git a/packages/eslint-plugin/tests/util/getWrappingFixer.test.ts b/packages/eslint-plugin/tests/util/getWrappingFixer.test.ts index 22306176211..bcbb4c6d5fb 100644 --- a/packages/eslint-plugin/tests/util/getWrappingFixer.test.ts +++ b/packages/eslint-plugin/tests/util/getWrappingFixer.test.ts @@ -10,7 +10,6 @@ const rule = createRule({ fixable: 'code', docs: { description: 'Add void operator in random places for test purposes.', - category: 'Stylistic Issues', recommended: false, }, messages: { diff --git a/packages/experimental-utils/src/ts-eslint/Rule.ts b/packages/experimental-utils/src/ts-eslint/Rule.ts index e17de9f6eba..9db521b2850 100644 --- a/packages/experimental-utils/src/ts-eslint/Rule.ts +++ b/packages/experimental-utils/src/ts-eslint/Rule.ts @@ -1,19 +1,11 @@ -import { JSONSchema4 } from '../json-schema'; -import { ParserServices, TSESTree } from '../ts-estree'; -import { AST } from './AST'; -import { Linter } from './Linter'; -import { Scope } from './Scope'; -import { SourceCode } from './SourceCode'; +import type { JSONSchema4 } from '../json-schema'; +import type { ParserServices, TSESTree } from '../ts-estree'; +import type { AST } from './AST'; +import type { Linter } from './Linter'; +import type { Scope } from './Scope'; +import type { SourceCode } from './SourceCode'; interface RuleMetaDataDocs { - /** - * The general category the rule falls within - */ - category: - | 'Best Practices' - | 'Stylistic Issues' - | 'Variables' - | 'Possible Errors'; /** * Concise description of the rule */ diff --git a/packages/experimental-utils/tests/eslint-utils/RuleCreator.test.ts b/packages/experimental-utils/tests/eslint-utils/RuleCreator.test.ts index 343d5f0e1aa..34b314b8a26 100644 --- a/packages/experimental-utils/tests/eslint-utils/RuleCreator.test.ts +++ b/packages/experimental-utils/tests/eslint-utils/RuleCreator.test.ts @@ -13,7 +13,6 @@ describe('RuleCreator', () => { meta: { docs: { description: 'some description', - category: 'Best Practices', recommended: 'error', requiresTypeChecking: true, }, @@ -31,7 +30,6 @@ describe('RuleCreator', () => { expect(rule.meta).toEqual({ docs: { description: 'some description', - category: 'Best Practices', url: 'test/test', recommended: 'error', requiresTypeChecking: true, diff --git a/yarn.lock b/yarn.lock index 80ea8600a6d..83194d3d9c8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4373,9 +4373,9 @@ eslint-visitor-keys@^3.0.0: integrity sha512-mJOZa35trBTb3IyRmo8xmKBZlxf+N7OnUl4+ZhJHs/r+0770Wh/LEACE2pqMGMe27G/4y8P2bYGk4J70IC5k1Q== eslint@^8.0.0-0: - version "8.0.0-beta.0" - resolved "https://registry.yarnpkg.com/eslint/-/eslint-8.0.0-beta.0.tgz#965fa5161b7cc93f1c82fb9c617a3814dc95ba38" - integrity sha512-Q5wCLXSpq+RIa9QBrmHApNCpgqjBU5aeQbVfeAuc9DyBIWzsdivbiirbCmYBrdoFWUoGSYCYWSIpqrS2une7jg== + version "8.0.0-beta.1" + resolved "https://registry.yarnpkg.com/eslint/-/eslint-8.0.0-beta.1.tgz#5cd74684dbcfd8abee08cc10de578294124539b5" + integrity sha512-+3EHhCIJHUXuksq6dUSe1Nv9+sdFaLfct6ZiWdFYrHU8u9tX6QQWGdKJQuQXUlUdhMMh6cchRFIQ7OqSAcyq7A== dependencies: "@eslint/eslintrc" "^1.0.0" "@humanwhocodes/config-array" "^0.6.0"