fix(eslint-plugin): [explicit-module-boundary-types] ignore functions…

… exported within typed object/array literals (#2805)
typescript-eslint · Nov 25, 2020 · 73a63ee · 73a63ee
1 parent 32b1b68
commit 73a63ee
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts b/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts
@@ -390,6 +390,10 @@ export default util.createRule<Options, MessageIds>({
     function ancestorHasReturnType(node: FunctionNode): boolean {
       let ancestor = node.parent;
 
+      if (ancestor?.type === AST_NODE_TYPES.Property) {
+        ancestor = ancestor.value;
+      }
+
       // if the ancestor is not a return, then this function was not returned at all, so we can exit early
       const isReturnStatement =
         ancestor?.type === AST_NODE_TYPES.ReturnStatement;

diff --git a/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts b/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts
@@ -661,6 +661,26 @@ export class A {
   b = A;
 }
     `,
+    `
+interface Foo {
+  f: (x: boolean) => boolean;
+}
+
+export const a: Foo[] = [
+  {
+    f: (x: boolean) => x,
+  },
+];
+    `,
+    `
+interface Foo {
+  f: (x: boolean) => boolean;
+}
+
+export const a: Foo = {
+  f: (x: boolean) => x,
+};
+    `,
   ],
   invalid: [
     {