fix(typescript-estree): persisted parse and module none (#1516)

typescript-eslint · Feb 3, 2020 · 7c70323 · 7c70323
1 parent 159b16e
commit 7c70323
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 2 deletions.
diff --git a/packages/typescript-estree/src/create-program/createDefaultProgram.ts b/packages/typescript-estree/src/create-program/createDefaultProgram.ts
@@ -39,7 +39,10 @@ function createDefaultProgram(
     return undefined;
   }
 
-  const compilerHost = ts.createCompilerHost(commandLine.options, true);
+  const compilerHost = ts.createCompilerHost(
+    commandLine.options,
+    /* setParentNodes */ true,
+  );
   const oldReadFile = compilerHost.readFile;
   compilerHost.readFile = (fileName: string): string | undefined =>
     path.normalize(fileName) === path.normalize(extra.filePath)

diff --git a/packages/typescript-estree/src/create-program/createIsolatedProgram.ts b/packages/typescript-estree/src/create-program/createIsolatedProgram.ts
@@ -46,7 +46,7 @@ function createIsolatedProgram(code: string, extra: Extra): ASTAndProgram {
         filename,
         code,
         ts.ScriptTarget.Latest,
-        true,
+        /* setParentNodes */ true,
         getScriptKind(extra, filename),
       );
     },

diff --git a/packages/typescript-estree/src/create-program/createWatchProgram.ts b/packages/typescript-estree/src/create-program/createWatchProgram.ts
@@ -218,6 +218,8 @@ function getProgramsForProjects(
 
     // cache watch program and return current program
     knownWatchProgramMap.set(tsconfigPath, programWatch);
+    // sets parent pointers in source files
+    program.getTypeChecker();
     results.push(program);
   }
 

diff --git a/packages/typescript-estree/tests/lib/persistentParse.ts b/packages/typescript-estree/tests/lib/persistentParse.ts
@@ -8,6 +8,9 @@ const CONTENTS = {
   bar: 'console.log("bar")',
   'baz/bar': 'console.log("baz bar")',
   'bat/baz/bar': 'console.log("bat/baz/bar")',
+  number: 'const foo = 1;',
+  object: '(() => { })();',
+  string: 'let a: "a" | "b";',
 };
 
 const cwdCopy = process.cwd();
@@ -304,4 +307,35 @@ describe('persistent parse', () => {
 
     baseTests(tsConfigExcludeBar, tsConfigIncludeAll);
   });
+
+  describe('tsconfig with module set', () => {
+    const moduleTypes = [
+      'None',
+      'CommonJS',
+      'AMD',
+      'System',
+      'UMD',
+      'ES6',
+      'ES2015',
+      'ESNext',
+    ];
+
+    for (const module of moduleTypes) {
+      describe(`module ${module}`, () => {
+        const tsConfigIncludeAll = {
+          compilerOptions: { module },
+          include: ['./**/*'],
+        };
+
+        const testNames = ['object', 'number', 'string', 'foo'] as const;
+        for (const name of testNames) {
+          it(`first parse of ${name} should not throw`, () => {
+            const PROJECT_DIR = setup(tsConfigIncludeAll);
+            writeFile(PROJECT_DIR, name);
+            expect(() => parseFile(name, PROJECT_DIR)).not.toThrow();
+          });
+        }
+      });
+    }
+  });
 });