fix(eslint-plugin): no-empty-interface autofix (#1865)

Resolves: #1864
typescript-eslint · Apr 8, 2020 · 829a2f7 · 829a2f7
1 parent 5832a86
commit 829a2f7
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 6 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-empty-interface.ts b/packages/eslint-plugin/src/rules/no-empty-interface.ts
@@ -61,13 +61,18 @@ export default util.createRule<Options, MessageIds>({
             context.report({
               node: node.id,
               messageId: 'noEmptyWithSuper',
-              fix: fixer =>
-                fixer.replaceText(
+              fix: fixer => {
+                let typeParam = '';
+                if (node.typeParameters) {
+                  typeParam = sourceCode.getText(node.typeParameters);
+                }
+                return fixer.replaceText(
                   node,
-                  `type ${sourceCode.getText(node.id)} = ${sourceCode.getText(
-                    extend[0],
-                  )}`,
-                ),
+                  `type ${sourceCode.getText(
+                    node.id,
+                  )}${typeParam} = ${sourceCode.getText(extend[0])}`,
+                );
+              },
             });
           }
         }

diff --git a/packages/eslint-plugin/tests/rules/no-empty-interface.test.ts b/packages/eslint-plugin/tests/rules/no-empty-interface.test.ts
@@ -133,5 +133,20 @@ type Foo = R
         },
       ],
     },
+    {
+      code: `
+interface Foo<T> extends Bar<T> {}
+      `,
+      output: noFormat`
+type Foo<T> = Bar<T>
+      `,
+      errors: [
+        {
+          messageId: 'noEmptyWithSuper',
+          line: 2,
+          column: 11,
+        },
+      ],
+    },
   ],
 });