fix(eslint-plugin): [array-type] parenthesize ReadonlyArray fix (#2747)

typescript-eslint · Nov 8, 2020 · 83385ac · 83385ac
1 parent 0d0af64
commit 83385ac
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 9 deletions.
diff --git a/packages/eslint-plugin/src/rules/array-type.ts b/packages/eslint-plugin/src/rules/array-type.ts
@@ -244,7 +244,14 @@ export default util.createRule<Options, MessageIds>({
         }
 
         const type = typeParams[0];
-        const parens = typeNeedsParentheses(type);
+        const typeParens = typeNeedsParentheses(type);
+        const parentParens =
+          readonlyPrefix && node.parent?.type === AST_NODE_TYPES.TSArrayType;
+
+        const start = `${parentParens ? '(' : ''}${readonlyPrefix}${
+          typeParens ? '(' : ''
+        }`;
+        const end = `${typeParens ? ')' : ''}[]${parentParens ? ')' : ''}`;
 
         context.report({
           node,
@@ -254,14 +261,8 @@ export default util.createRule<Options, MessageIds>({
           },
           fix(fixer) {
             return [
-              fixer.replaceTextRange(
-                [node.range[0], type.range[0]],
-                `${readonlyPrefix}${parens ? '(' : ''}`,
-              ),
-              fixer.replaceTextRange(
-                [type.range[1], node.range[1]],
-                parens ? ')[]' : '[]',
-              ),
+              fixer.replaceTextRange([node.range[0], type.range[0]], start),
+              fixer.replaceTextRange([type.range[1], node.range[1]], end),
             ];
           },
         });

diff --git a/packages/eslint-plugin/tests/rules/array-type.test.ts b/packages/eslint-plugin/tests/rules/array-type.test.ts
@@ -1648,6 +1648,19 @@ interface FooInterface {
         },
       ],
     },
+    {
+      code: 'type Foo = ReadonlyArray<object>[];',
+      output: 'type Foo = (readonly object[])[];',
+      options: [{ default: 'array' }],
+      errors: [
+        {
+          messageId: 'errorStringArray',
+          data: { type: 'object' },
+          line: 1,
+          column: 12,
+        },
+      ],
+    },
   ],
 });