From 84db88d1e6a05ae94605e833779973f545ac3587 Mon Sep 17 00:00:00 2001
From: Song Xie <me@xiesong.me>
Date: Fri, 22 Apr 2022 23:16:05 -0700
Subject: [PATCH] fix(eslint-plugin): test falsy values and fix some metadata

---
 .../src/rules/no-duplicate-enum-values.ts     |  5 ++---
 .../rules/no-duplicate-enum-values.test.ts    | 19 +++++++++++++++----
 2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/packages/eslint-plugin/src/rules/no-duplicate-enum-values.ts b/packages/eslint-plugin/src/rules/no-duplicate-enum-values.ts
index f5f045f7de43..3ede60b9fc37 100644
--- a/packages/eslint-plugin/src/rules/no-duplicate-enum-values.ts
+++ b/packages/eslint-plugin/src/rules/no-duplicate-enum-values.ts
@@ -8,11 +8,10 @@ export default util.createRule({
     docs: {
       description: 'Disallow duplicate enum member values',
       recommended: false,
-      suggestion: true,
     },
     hasSuggestions: true,
     messages: {
-      duplicateMember: 'Duplicate enum member with value {{value}}.',
+      duplicateValue: 'Duplicate enum member value {{value}}.',
     },
     schema: [],
   },
@@ -58,7 +57,7 @@ export default util.createRule({
           if (seenValues.has(value)) {
             context.report({
               node: member,
-              messageId: 'duplicateMember',
+              messageId: 'duplicateValue',
               data: {
                 value,
               },
diff --git a/packages/eslint-plugin/tests/rules/no-duplicate-enum-values.test.ts b/packages/eslint-plugin/tests/rules/no-duplicate-enum-values.test.ts
index dd59f867e2fd..a05a604dc804 100644
--- a/packages/eslint-plugin/tests/rules/no-duplicate-enum-values.test.ts
+++ b/packages/eslint-plugin/tests/rules/no-duplicate-enum-values.test.ts
@@ -59,6 +59,17 @@ enum E {
   B = 'B',
   C = 2,
   D = foo(),
+}
+    `,
+    `
+enum E {
+  A = false,
+  B = 0,
+  C = -0,
+  D = 0n,
+  E = null,
+  F = undefined,
+  G = NaN,
 }
     `,
   ],
@@ -74,7 +85,7 @@ enum E {
         {
           line: 4,
           column: 3,
-          messageId: 'duplicateMember',
+          messageId: 'duplicateValue',
           data: { value: 1 },
         },
       ],
@@ -90,7 +101,7 @@ enum E {
         {
           line: 4,
           column: 3,
-          messageId: 'duplicateMember',
+          messageId: 'duplicateValue',
           data: { value: 'A' },
         },
       ],
@@ -108,13 +119,13 @@ enum E {
         {
           line: 4,
           column: 3,
-          messageId: 'duplicateMember',
+          messageId: 'duplicateValue',
           data: { value: 'A' },
         },
         {
           line: 6,
           column: 3,
-          messageId: 'duplicateMember',
+          messageId: 'duplicateValue',
           data: { value: 1 },
         },
       ],