fix(eslint-plugin): [sort-type-union-intersection-members] Wrap the c…

…onstructorType in parentheses (#4590) Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
typescript-eslint · Feb 24, 2022 · 851bb90 · 851bb90
1 parent 6afcaea
commit 851bb90
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/sort-type-union-intersection-members.ts b/packages/eslint-plugin/src/rules/sort-type-union-intersection-members.ts
@@ -85,7 +85,10 @@ function getGroup(node: TSESTree.TypeNode): Group {
 }
 
 function requiresParentheses(node: TSESTree.TypeNode): boolean {
-  return node.type === AST_NODE_TYPES.TSFunctionType;
+  return (
+    node.type === AST_NODE_TYPES.TSFunctionType ||
+    node.type === AST_NODE_TYPES.TSConstructorType
+  );
 }
 
 export type Options = [

diff --git a/packages/eslint-plugin/tests/rules/sort-type-union-intersection-members.test.ts b/packages/eslint-plugin/tests/rules/sort-type-union-intersection-members.test.ts
@@ -272,6 +272,15 @@ type T =
         },
       ],
     },
+    {
+      code: `type Expected = (new (x: number) => boolean) ${operator} string;`,
+      output: `type Expected = string ${operator} (new (x: number) => boolean);`,
+      errors: [
+        {
+          messageId: 'notSortedNamed',
+        },
+      ],
+    },
   ];
 };