fix(eslint-plugin): [prefer-readonly] correct issue with anonymus fun…

…ctions (#4974) * fix(eslint-plugin): [prefer-readonly] correct issue with anonymus functions #2590 * test(eslint-plugin): add missing invalid case Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
typescript-eslint · May 23, 2022 · 952e2f0 · 952e2f0
1 parent 1012e0b
commit 952e2f0
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/prefer-readonly.ts b/packages/eslint-plugin/src/rules/prefer-readonly.ts
@@ -270,8 +270,12 @@ class ClassScope {
     classNode: ts.ClassLikeDeclaration,
     private readonly onlyInlineLambdas?: boolean,
   ) {
-    this.checker = checker;
-    this.classType = checker.getTypeAtLocation(classNode);
+    const classType = checker.getTypeAtLocation(classNode);
+    if (tsutils.isIntersectionType(classType)) {
+      this.classType = classType.types[0];
+    } else {
+      this.classType = classType;
+    }
 
     for (const member of classNode.members) {
       if (ts.isPropertyDeclaration(member)) {

diff --git a/packages/eslint-plugin/tests/rules/prefer-readonly.test.ts b/packages/eslint-plugin/tests/rules/prefer-readonly.test.ts
@@ -292,6 +292,19 @@ class Foo {
     },
     {
       code: `
+function ClassWithName<TBase extends new (...args: any[]) => {}>(Base: TBase) {
+  return class extends Base {
+    private _name: string;
+
+    public test(value: string) {
+      this._name = value;
+    }
+  };
+}
+      `,
+    },
+    {
+      code: `
 class Foo {
   private value: Record<string, number> = {};
 
@@ -704,5 +717,30 @@ class Foo {
         }
       `,
     },
+    {
+      code: `
+function ClassWithName<TBase extends new (...args: any[]) => {}>(Base: TBase) {
+  return class extends Base {
+    private _name: string;
+  };
+}
+      `,
+      output: `
+function ClassWithName<TBase extends new (...args: any[]) => {}>(Base: TBase) {
+  return class extends Base {
+    private readonly _name: string;
+  };
+}
+      `,
+      errors: [
+        {
+          data: {
+            name: '_name',
+          },
+          line: 4,
+          messageId: 'preferReadonly',
+        },
+      ],
+    },
   ],
 });