fix(eslint-plugin): [no-inferrable] fix optional param to valid code (#…

…5342) * fix(eslint-plugin): [no-inferrable] fix optional param to valid code * Add definite assignment
typescript-eslint · Jul 18, 2022 · 98f6d5e · 98f6d5e
1 parent 9ed8fe3
commit 98f6d5e
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-inferrable-types.ts b/packages/eslint-plugin/src/rules/no-inferrable-types.ts
@@ -46,6 +46,8 @@ export default util.createRule<Options, MessageIds>({
     },
   ],
   create(context, [{ ignoreParameters, ignoreProperties }]) {
+    const sourceCode = context.getSourceCode();
+
     function isFunctionCall(
       init: TSESTree.Expression,
       callName: string,
@@ -215,7 +217,16 @@ export default util.createRule<Options, MessageIds>({
         data: {
           type,
         },
-        fix: fixer => fixer.remove(typeNode),
+        *fix(fixer) {
+          if (
+            (node.type === AST_NODE_TYPES.AssignmentPattern &&
+              node.left.optional) ||
+            (node.type === AST_NODE_TYPES.PropertyDefinition && node.definite)
+          ) {
+            yield fixer.remove(sourceCode.getTokenBefore(typeNode)!);
+          }
+          yield fixer.remove(typeNode);
+        },
       });
     }
 

diff --git a/packages/eslint-plugin/tests/rules/no-inferrable-types.test.ts b/packages/eslint-plugin/tests/rules/no-inferrable-types.test.ts
@@ -156,7 +156,54 @@ class Foo {
 
   invalid: [
     ...invalidTestCases,
-
+    {
+      // This is invalid TS semantic, but it's trivial to make valid anyway
+      code: 'const fn = (a?: number = 5) => {};',
+      output: 'const fn = (a = 5) => {};',
+      options: [
+        {
+          ignoreParameters: false,
+        },
+      ],
+      errors: [
+        {
+          messageId: 'noInferrableType',
+          data: {
+            type: 'number',
+          },
+          line: 1,
+          column: 13,
+        },
+      ],
+    },
+    {
+      // This is invalid TS semantic, but it's trivial to make valid anyway
+      code: `
+class A {
+  a!: number = 1;
+}
+      `,
+      output: `
+class A {
+  a = 1;
+}
+      `,
+      options: [
+        {
+          ignoreProperties: false,
+        },
+      ],
+      errors: [
+        {
+          messageId: 'noInferrableType',
+          data: {
+            type: 'number',
+          },
+          line: 3,
+          column: 3,
+        },
+      ],
+    },
     {
       code: "const fn = (a: number = 5, b: boolean = true, c: string = 'foo') => {};",
       output: "const fn = (a = 5, b = true, c = 'foo') => {};",