feat(eslint-plugin): [no-var-requires] report on foo(require('')) (#725)

Fixes #665
typescript-eslint · Jul 24, 2019 · b2ca20d · b2ca20d
1 parent 35dec52
commit b2ca20d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/no-var-requires.ts b/packages/eslint-plugin/src/rules/no-var-requires.ts
@@ -27,7 +27,8 @@ export default util.createRule<Options, MessageIds>({
           node.callee.type === AST_NODE_TYPES.Identifier &&
           node.callee.name === 'require' &&
           node.parent &&
-          node.parent.type === AST_NODE_TYPES.VariableDeclarator
+          (node.parent.type === AST_NODE_TYPES.VariableDeclarator ||
+            node.parent.type === AST_NODE_TYPES.CallExpression)
         ) {
           context.report({
             node,

diff --git a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts
@@ -38,5 +38,15 @@ ruleTester.run('no-var-requires', rule, {
         },
       ],
     },
+    {
+      code: "let foo = trick(require('foo'))",
+      errors: [
+        {
+          messageId: 'noVarReqs',
+          line: 1,
+          column: 17,
+        },
+      ],
+    },
   ],
 });