From b2ca20d005d6a626319c76da121aea44df26ab53 Mon Sep 17 00:00:00 2001 From: Jaya Krishna Namburu Date: Wed, 24 Jul 2019 21:07:24 +0530 Subject: [PATCH] feat(eslint-plugin): [no-var-requires] report on foo(require('')) (#725) Fixes #665 --- packages/eslint-plugin/src/rules/no-var-requires.ts | 3 ++- .../eslint-plugin/tests/rules/no-var-requires.test.ts | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin/src/rules/no-var-requires.ts b/packages/eslint-plugin/src/rules/no-var-requires.ts index 8d8e714c4f5..29b1c77dd34 100644 --- a/packages/eslint-plugin/src/rules/no-var-requires.ts +++ b/packages/eslint-plugin/src/rules/no-var-requires.ts @@ -27,7 +27,8 @@ export default util.createRule({ node.callee.type === AST_NODE_TYPES.Identifier && node.callee.name === 'require' && node.parent && - node.parent.type === AST_NODE_TYPES.VariableDeclarator + (node.parent.type === AST_NODE_TYPES.VariableDeclarator || + node.parent.type === AST_NODE_TYPES.CallExpression) ) { context.report({ node, diff --git a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts index f209c2069f0..b042ac1f806 100644 --- a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts +++ b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts @@ -38,5 +38,15 @@ ruleTester.run('no-var-requires', rule, { }, ], }, + { + code: "let foo = trick(require('foo'))", + errors: [ + { + messageId: 'noVarReqs', + line: 1, + column: 17, + }, + ], + }, ], });