fix(eslint-plugin): [no-unused-vars] handle TSCallSignature (#2336)

typescript-eslint · Aug 29, 2020 · c70f54f · c70f54f
1 parent 3be125d
commit c70f54f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/no-unused-vars.ts b/packages/eslint-plugin/src/rules/no-unused-vars.ts
@@ -84,8 +84,9 @@ export default util.createRule<Options, MessageIds>({
 
     return {
       ...rules,
-      'TSConstructorType, TSConstructSignatureDeclaration, TSDeclareFunction, TSEmptyBodyFunctionExpression, TSFunctionType, TSMethodSignature'(
+      'TSCallSignatureDeclaration, TSConstructorType, TSConstructSignatureDeclaration, TSDeclareFunction, TSEmptyBodyFunctionExpression, TSFunctionType, TSMethodSignature'(
         node:
+          | TSESTree.TSCallSignatureDeclaration
           | TSESTree.TSConstructorType
           | TSESTree.TSConstructSignatureDeclaration
           | TSESTree.TSDeclareFunction

diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars.test.ts
@@ -729,6 +729,26 @@ export function foo() {
   return new Promise<Foo>();
 }
     `,
+    // https://github.com/typescript-eslint/typescript-eslint/issues/2331
+    {
+      code: `
+export interface Event<T> {
+  (
+    listener: (e: T) => any,
+    thisArgs?: any,
+    disposables?: Disposable[],
+  ): Disposable;
+}
+      `,
+      options: [
+        {
+          args: 'after-used',
+          argsIgnorePattern: '^_',
+          ignoreRestSiblings: true,
+          varsIgnorePattern: '^_$',
+        },
+      ],
+    },
   ],
 
   invalid: [