fix(eslint-plugin): [no-implied-eval] handle the Function type (#2435)

typescript-eslint · Sep 14, 2020 · e1401dc · e1401dc
1 parent 7ca54c3
commit e1401dc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-implied-eval.ts b/packages/eslint-plugin/src/rules/no-implied-eval.ts
@@ -80,6 +80,16 @@ export default util.createRule({
         return true;
       }
 
+      if (symbol && symbol.escapedName === FUNCTION_CONSTRUCTOR) {
+        const declarations = symbol.getDeclarations() ?? [];
+        for (const declaration of declarations) {
+          const sourceFile = declaration.getSourceFile();
+          if (program.isSourceFileDefaultLibrary(sourceFile)) {
+            return true;
+          }
+        }
+      }
+
       const signatures = checker.getSignaturesOfType(
         type,
         ts.SignatureKind.Call,

diff --git a/packages/eslint-plugin/tests/rules/no-implied-eval.test.ts b/packages/eslint-plugin/tests/rules/no-implied-eval.test.ts
@@ -246,6 +246,11 @@ const fn = (foo: () => void) => {
 import { Function } from './class';
 new Function('foo');
     `,
+    `
+const foo = (callback: Function) => {
+  setTimeout(callback, 0);
+};
+    `,
   ],
 
   invalid: [