fix(eslint-plugin): [pfa] Allow async getter/setter in classes (#980)

typescript-eslint · Sep 17, 2019 · e348cb2 · e348cb2
1 parent fa1cf71
commit e348cb2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/promise-function-async.ts b/packages/eslint-plugin/src/rules/promise-function-async.ts
@@ -105,7 +105,8 @@ export default util.createRule<Options, MessageIds>({
 
       if (
         node.parent &&
-        node.parent.type === 'Property' &&
+        (node.parent.type === 'Property' ||
+          node.parent.type === 'MethodDefinition') &&
         (node.parent.kind === 'get' || node.parent.kind === 'set')
       ) {
         return;

diff --git a/packages/eslint-plugin/tests/rules/promise-function-async.test.ts b/packages/eslint-plugin/tests/rules/promise-function-async.test.ts
@@ -54,6 +54,12 @@ class InvalidAsyncModifiers {
   public set asyncGetter(p: Promise<void>) {
     return p;
   }
+  public get asyncGetterFunc() {
+    return async () => new Promise<void>();
+  }
+  public set asyncGetterFunc(p: () => Promise<void>) {
+    return p;
+  }
 }
     `,
     `