fix(eslint-plugin): [prefer-literal-enum-member] allow pure template …

…literal strings (#2786)
typescript-eslint · Nov 19, 2020 · f3bf6a1 · f3bf6a1
1 parent 7af66a7
commit f3bf6a1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts b/packages/eslint-plugin/src/rules/prefer-literal-enum-member.ts
@@ -29,6 +29,13 @@ export default createRule({
         if (node.initializer.type === AST_NODE_TYPES.Literal) {
           return;
         }
+        // TemplateLiteral without expressions
+        if (
+          node.initializer.type === AST_NODE_TYPES.TemplateLiteral &&
+          node.initializer.expressions.length === 0
+        ) {
+          return;
+        }
         // -1 and +1
         if (
           node.initializer.type === AST_NODE_TYPES.UnaryExpression &&

diff --git a/packages/eslint-plugin/tests/rules/prefer-literal-enum-member.test.ts b/packages/eslint-plugin/tests/rules/prefer-literal-enum-member.test.ts
@@ -18,6 +18,11 @@ enum ValidString {
 }
     `,
     `
+enum ValidLiteral {
+  A = \`test\`,
+}
+    `,
+    `
 enum ValidNumber {
   A = 42,
 }
@@ -90,7 +95,7 @@ enum InvalidArray {
     {
       code: `
 enum InvalidTemplateLiteral {
-  A = \`a\`,
+  A = \`foo \${0}\`,
 }
       `,
       errors: [