Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(types): remove leftovers from removal of useJSXTextNode (#5091)
  • Loading branch information
armano2 committed May 28, 2022
1 parent c4310b1 commit f9c3647
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion packages/parser/src/parser.ts
Expand Up @@ -98,7 +98,6 @@ function parseForESLint(

const parserOptions: TSESTreeOptions = {};
Object.assign(parserOptions, options, {
useJSXTextNode: validateBoolean(options.useJSXTextNode, true),
jsx: validateBoolean(options.ecmaFeatures.jsx),
});
const analyzeOptions: AnalyzeOptions = {
Expand Down
4 changes: 0 additions & 4 deletions packages/parser/tests/lib/parser.ts
Expand Up @@ -40,7 +40,6 @@ describe('parser', () => {
// ts-estree specific
filePath: 'isolated-file.src.ts',
project: 'tsconfig.json',
useJSXTextNode: false,
errorOnUnknownASTType: false,
errorOnTypeScriptSyntacticAndSemanticIssues: false,
tsconfigRootDir: 'tests/fixtures/services',
Expand All @@ -62,7 +61,6 @@ describe('parser', () => {
ecmaFeatures: {},
jsx: false,
sourceType: 'script',
useJSXTextNode: true,
warnOnUnsupportedTypeScriptVersion: true,
});
spy.mockClear();
Expand All @@ -71,7 +69,6 @@ describe('parser', () => {
ecmaFeatures: {},
jsx: false,
sourceType: 'script',
useJSXTextNode: true,
loggerFn: false,
warnOnUnsupportedTypeScriptVersion: false,
});
Expand All @@ -98,7 +95,6 @@ describe('parser', () => {
// ts-estree specific
filePath: 'isolated-file.src.ts',
project: 'tsconfig.json',
useJSXTextNode: false,
errorOnUnknownASTType: false,
errorOnTypeScriptSyntacticAndSemanticIssues: false,
tsconfigRootDir: 'tests/fixtures/services',
Expand Down
1 change: 0 additions & 1 deletion packages/types/src/parser-options.ts
Expand Up @@ -56,7 +56,6 @@ interface ParserOptions {
sourceType?: SourceType;
tokens?: boolean;
tsconfigRootDir?: string;
useJSXTextNode?: boolean;
warnOnUnsupportedTypeScriptVersion?: boolean;
moduleResolver?: string;
}
Expand Down
Expand Up @@ -455,8 +455,8 @@ tester.addFixturePatternConfig('typescript/expressions', {
fileType: 'ts',
ignore: [
/**
* Produced AST is different
* TODO: investigate in more details
* Babel produces incorrect structure for TSInstantiationExpression and optional ChainExpression
* @see https://github.com/babel/babel/issues/14613
*/
'instantiation-expression',
],
Expand Down

0 comments on commit f9c3647

Please sign in to comment.