From f9c3647cb637c8d1ee461b471da9d817ccbde77c Mon Sep 17 00:00:00 2001 From: Armano Date: Sat, 28 May 2022 23:28:47 +0200 Subject: [PATCH] fix(types): remove leftovers from removal of useJSXTextNode (#5091) --- packages/parser/src/parser.ts | 1 - packages/parser/tests/lib/parser.ts | 4 ---- packages/types/src/parser-options.ts | 1 - .../typescript-estree/tests/ast-alignment/fixtures-to-test.ts | 4 ++-- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/parser/src/parser.ts b/packages/parser/src/parser.ts index 7fcd45f96f7..94689968cac 100644 --- a/packages/parser/src/parser.ts +++ b/packages/parser/src/parser.ts @@ -98,7 +98,6 @@ function parseForESLint( const parserOptions: TSESTreeOptions = {}; Object.assign(parserOptions, options, { - useJSXTextNode: validateBoolean(options.useJSXTextNode, true), jsx: validateBoolean(options.ecmaFeatures.jsx), }); const analyzeOptions: AnalyzeOptions = { diff --git a/packages/parser/tests/lib/parser.ts b/packages/parser/tests/lib/parser.ts index ba319185b1f..096905b23aa 100644 --- a/packages/parser/tests/lib/parser.ts +++ b/packages/parser/tests/lib/parser.ts @@ -40,7 +40,6 @@ describe('parser', () => { // ts-estree specific filePath: 'isolated-file.src.ts', project: 'tsconfig.json', - useJSXTextNode: false, errorOnUnknownASTType: false, errorOnTypeScriptSyntacticAndSemanticIssues: false, tsconfigRootDir: 'tests/fixtures/services', @@ -62,7 +61,6 @@ describe('parser', () => { ecmaFeatures: {}, jsx: false, sourceType: 'script', - useJSXTextNode: true, warnOnUnsupportedTypeScriptVersion: true, }); spy.mockClear(); @@ -71,7 +69,6 @@ describe('parser', () => { ecmaFeatures: {}, jsx: false, sourceType: 'script', - useJSXTextNode: true, loggerFn: false, warnOnUnsupportedTypeScriptVersion: false, }); @@ -98,7 +95,6 @@ describe('parser', () => { // ts-estree specific filePath: 'isolated-file.src.ts', project: 'tsconfig.json', - useJSXTextNode: false, errorOnUnknownASTType: false, errorOnTypeScriptSyntacticAndSemanticIssues: false, tsconfigRootDir: 'tests/fixtures/services', diff --git a/packages/types/src/parser-options.ts b/packages/types/src/parser-options.ts index c54d38c73b9..bb5101768e0 100644 --- a/packages/types/src/parser-options.ts +++ b/packages/types/src/parser-options.ts @@ -56,7 +56,6 @@ interface ParserOptions { sourceType?: SourceType; tokens?: boolean; tsconfigRootDir?: string; - useJSXTextNode?: boolean; warnOnUnsupportedTypeScriptVersion?: boolean; moduleResolver?: string; } diff --git a/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts b/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts index 5e15137728f..1d0b6ac64ca 100644 --- a/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts +++ b/packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts @@ -455,8 +455,8 @@ tester.addFixturePatternConfig('typescript/expressions', { fileType: 'ts', ignore: [ /** - * Produced AST is different - * TODO: investigate in more details + * Babel produces incorrect structure for TSInstantiationExpression and optional ChainExpression + * @see https://github.com/babel/babel/issues/14613 */ 'instantiation-expression', ],