fix(eslint-plugin): [typedef] fix regression with class properties (#…

…4034) Fixes #4033
typescript-eslint · Oct 20, 2021 · fe53d22 · fe53d22
1 parent 600d413
commit fe53d22
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/typedef.ts b/packages/eslint-plugin/src/rules/typedef.ts
@@ -175,8 +175,7 @@ export default util.createRule<[Options], MessageIds>({
       ...(memberVariableDeclaration && {
         PropertyDefinition(node): void {
           if (
-            !node.value ||
-            !isVariableDeclarationIgnoreFunction(node.value) ||
+            !(node.value && isVariableDeclarationIgnoreFunction(node.value)) &&
             !node.typeAnnotation
           ) {
             report(

diff --git a/packages/eslint-plugin/tests/rules/typedef.test.ts b/packages/eslint-plugin/tests/rules/typedef.test.ts
@@ -442,6 +442,24 @@ class Foo {
         },
       ],
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/4033
+    {
+      code: `
+class ClassName {
+  public str: string = 'str';
+  #num: number = 13;
+
+  func: () => void = (): void => {
+    console.log(this.str);
+  };
+}
+      `,
+      options: [
+        {
+          memberVariableDeclaration: true,
+        },
+      ],
+    },
   ],
   invalid: [
     // Array destructuring