From fe910e61ca4bb42be3be9acb8ddcec73206754c2 Mon Sep 17 00:00:00 2001
From: Taeheon Kim <skyrabbits1@gmail.com>
Date: Mon, 14 Feb 2022 15:04:37 +0900
Subject: [PATCH] fix(eslint-plugin): [init-declarations] fix nested namespace
 (#4544)

---
 .../src/rules/init-declarations.ts            | 25 ++++++--
 .../tests/rules/init-declarations.test.ts     | 60 +++++++++++++++++++
 2 files changed, 80 insertions(+), 5 deletions(-)

diff --git a/packages/eslint-plugin/src/rules/init-declarations.ts b/packages/eslint-plugin/src/rules/init-declarations.ts
index 611687b0e9f..a10035c0691 100644
--- a/packages/eslint-plugin/src/rules/init-declarations.ts
+++ b/packages/eslint-plugin/src/rules/init-declarations.ts
@@ -35,11 +35,7 @@ export default createRule<Options, MessageIds>({
           if (node.declare) {
             return;
           }
-          if (
-            node.parent?.type === AST_NODE_TYPES.TSModuleBlock &&
-            node.parent.parent?.type === AST_NODE_TYPES.TSModuleDeclaration &&
-            node.parent.parent?.declare
-          ) {
+          if (isAncestorNamespaceDeclared(node)) {
             return;
           }
         }
@@ -47,5 +43,24 @@ export default createRule<Options, MessageIds>({
         rules['VariableDeclaration:exit'](node);
       },
     };
+
+    function isAncestorNamespaceDeclared(
+      node: TSESTree.VariableDeclaration,
+    ): boolean {
+      let ancestor = node.parent;
+
+      while (ancestor) {
+        if (
+          ancestor.type === AST_NODE_TYPES.TSModuleDeclaration &&
+          ancestor.declare
+        ) {
+          return true;
+        }
+
+        ancestor = ancestor.parent;
+      }
+
+      return false;
+    }
   },
 });
diff --git a/packages/eslint-plugin/tests/rules/init-declarations.test.ts b/packages/eslint-plugin/tests/rules/init-declarations.test.ts
index 95d9a08799a..29e9025f734 100644
--- a/packages/eslint-plugin/tests/rules/init-declarations.test.ts
+++ b/packages/eslint-plugin/tests/rules/init-declarations.test.ts
@@ -341,6 +341,35 @@ namespace myLib {
       `,
       options: ['always'],
     },
+    {
+      code: `
+declare namespace myLib1 {
+  const foo: number;
+  namespace myLib2 {
+    let bar: string;
+    namespace myLib3 {
+      let baz: object;
+    }
+  }
+}
+      `,
+      options: ['always'],
+    },
+
+    {
+      code: `
+declare namespace myLib1 {
+  const foo: number;
+  namespace myLib2 {
+    let bar: string;
+    namespace myLib3 {
+      let baz: object;
+    }
+  }
+}
+      `,
+      options: ['never'],
+    },
   ],
   invalid: [
     // checking compatibility with base rule
@@ -724,5 +753,36 @@ namespace myLib {
         },
       ],
     },
+    {
+      code: `
+namespace myLib1 {
+  const foo: number;
+  namespace myLib2 {
+    let bar: string;
+    namespace myLib3 {
+      let baz: object;
+    }
+  }
+}
+      `,
+      options: ['always'],
+      errors: [
+        {
+          messageId: 'initialized',
+          data: { idName: 'foo' },
+          type: AST_NODE_TYPES.VariableDeclarator,
+        },
+        {
+          messageId: 'initialized',
+          data: { idName: 'bar' },
+          type: AST_NODE_TYPES.VariableDeclarator,
+        },
+        {
+          messageId: 'initialized',
+          data: { idName: 'baz' },
+          type: AST_NODE_TYPES.VariableDeclarator,
+        },
+      ],
+    },
   ],
 });