Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnec-type-arg] undefined symbol crash #1007

Conversation

quentin-jaquier-sonarsource
Copy link
Contributor

Fixes #1006

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @quentin-jaquier-sonarsource!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #1007 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   94.13%   94.14%   +<.01%     
==========================================
  Files         115      115              
  Lines        5016     5019       +3     
  Branches     1403     1404       +1     
==========================================
+ Hits         4722     4725       +3     
  Misses        166      166              
  Partials      128      128
Impacted Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-arguments.ts 91.66% <100%> (+0.55%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Sep 24, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this

@bradzacher bradzacher changed the title fix(eslint-plugin): check symbol at location for undefined fix(eslint-plugin): [no-unnec-type-arg] undefined symbol crash Sep 24, 2019
@bradzacher bradzacher merged commit cdf9294 into typescript-eslint:master Sep 24, 2019
@quentin-jaquier-sonarsource
Copy link
Contributor Author

Thanks for your quick reaction.

Funny story, I realized that this issue was in fact reported by... the plugin itself (rule no-non-null-assertion)!
Too bad we did not manage to eat our own dog food to prevent this bug!
Still, it's nice to see that this rule is reporting relevant true positive 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-type-arguments] TypeError when Symbol is not defined
2 participants