Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Optional Chaining in Typescript Parser #1035

Closed
justinmwarner opened this issue Oct 2, 2019 · 5 comments
Closed

Support Optional Chaining in Typescript Parser #1035

justinmwarner opened this issue Oct 2, 2019 · 5 comments
Labels
package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look

Comments

@justinmwarner
Copy link

What code were you trying to parse?

// Please put code here
  const obj = {name: ""};
  return {
    name: obj?.name,
    ...additionalData,
  };

What did you expect to happen?
No error, parses fine, and shows in IDE fine.

What actually happened?
image
image
image

Versions

package version
@typescript-eslint/parser ^2.3.1
TypeScript ^3.7.0-dev.20191002
ESLint 6.1.0
node 10.16.3
npm 6.9.0

Expected to land in 3.7.x from Typescript-
https://github.com/Microsoft/TypeScript/wiki/Roadmap#37-november-2019
microsoft/TypeScript#33294

Relates to #136

@justinmwarner justinmwarner added package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look labels Oct 2, 2019
@AlCalzone
Copy link

This breaks Prettier auto-formatting too, if that is done via eslint.

@bradzacher
Copy link
Member

3.7 beta was only just released (and the PRs for nullish coalescing / optional chaining were only merged a few days ago).

Please give us some time to add the features.

duplicate #1033

@AlCalzone
Copy link

No worries, just thought you might want to know the implications.

@matiishyn
Copy link

any updated on this one?

@justinmwarner
Copy link
Author

any updated on this one?

@matiishyn , look at #1033 , looks like eslint is good to go, prettier is still working on it. See the other ticket for the prettier items.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look
Projects
None yet
Development

No branches or pull requests

4 participants