New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condition-checking rules should check array callbacks #1038
Comments
@ark120202 because the pull request didn't have the "Fixes" directive this wasn't automatically closed, would you mind closing it for house keeping purposes? |
It doesn't sound like it was completely resolved. Only |
right sorry, was focused on the pull request I see now you mention those rules in your initial comment. I have already advocated for this in Not sure if this feels right to put in |
To make iteration methods be more similar to regular conditions their return types were changed to
unknown
(see microsoft/TypeScript#7779 and microsoft/TypeScript#31076). Rules that check conditions (strict-boolean-expressions
,no-unnecessary-condition
andno-misused-promises
) can be quite useful to make make it saferThe text was updated successfully, but these errors were encountered: