Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add no-extra-non-null-assertion #1183

Merged

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1170

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #1183 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   94.17%   94.06%   -0.11%     
==========================================
  Files         124      124              
  Lines        5322     5291      -31     
  Branches     1492     1470      -22     
==========================================
- Hits         5012     4977      -35     
- Misses        177      179       +2     
- Partials      133      135       +2
Impacted Files Coverage Δ
...nt-plugin/src/rules/no-extra-non-null-assertion.ts 100% <100%> (ø)
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin/src/rules/camelcase.ts 82.14% <0%> (-8.77%) ⬇️
packages/eslint-plugin/src/rules/require-await.ts 92.68% <0%> (-7.32%) ⬇️
...ges/typescript-estree/src/create-program/shared.ts 77.77% <0%> (-2.23%) ⬇️
...-plugin/src/rules/no-unnecessary-type-assertion.ts 88.15% <0%> (-0.45%) ⬇️
packages/eslint-plugin/src/rules/indent.ts 92.3% <0%> (-0.38%) ⬇️
...-plugin/src/rules/no-unnecessary-type-arguments.ts 91.66% <0%> (-0.34%) ⬇️
packages/eslint-plugin/src/rules/no-type-alias.ts 94.82% <0%> (-0.26%) ⬇️
... and 8 more

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and simple. LGTM!

@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: No multi non null assertion
2 participants