Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [member-ordering] add index signature #1190

Merged
merged 2 commits into from Dec 3, 2019
Merged

feat(eslint-plugin): [member-ordering] add index signature #1190

merged 2 commits into from Dec 3, 2019

Conversation

sveyret
Copy link
Contributor

@sveyret sveyret commented Nov 10, 2019

Issue #1186 Add the index signature to ordering analysis.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sveyret!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Issue #1186 Add the index signature to ordering analysis.
@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

Merging #1190 into master will decrease coverage by 0.07%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
- Coverage   94.01%   93.93%   -0.08%     
==========================================
  Files         131      131              
  Lines        5797     5804       +7     
  Branches     1638     1639       +1     
==========================================
+ Hits         5450     5452       +2     
- Misses        186      188       +2     
- Partials      161      164       +3
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 92.3% <100%> (-5.03%) ⬇️
packages/eslint-plugin/src/util/misc.ts 86.2% <75%> (-1.8%) ⬇️

@sveyret
Copy link
Contributor Author

sveyret commented Nov 10, 2019

Coverage lowering is due to lines that should normally never be reached.

@bradzacher bradzacher changed the title feat(eslint-plugin - member-ordering): add index signature feat(eslint-plugin): [member-ordering] add index signature Nov 10, 2019
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 10, 2019
@sveyret
Copy link
Contributor Author

sveyret commented Nov 13, 2019

@bradzacher, is there still something I should do or shall I just wait for review?

@bradzacher
Copy link
Member

It's in the queue of PRs to review.
Sit tight, and we'll get around to it soon enough.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants