Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camelcase] Add option to disable checking on library imports? #1210

Closed
Zjaaspoer opened this issue Nov 15, 2019 · 3 comments
Closed

[camelcase] Add option to disable checking on library imports? #1210

Zjaaspoer opened this issue Nov 15, 2019 · 3 comments
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule external This issue is with another package, not typescript-eslint itself package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@Zjaaspoer
Copy link

(As this is a feature request I didn't use the template. If you guys want me to fill it in, let me know and I will)

For the camelcase rule does it make sense to add an option to not check imports from 3rd party libraries? As you have no influence on their naming checking not checking those names would be a nice opt-out IMO.

I understand that you could rename the imports using the ... as ... convention, but there are plenty of use cases where people prefer not to.

(BTW I tried if the ignoreDestructuring option works, as named importing is technically object destructuring, but alas!)
@Zjaaspoer Zjaaspoer added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Nov 15, 2019
@bradzacher bradzacher added enhancement: plugin rule option New rule option for an existing eslint-plugin rule and removed triage Waiting for maintainers to take a look labels Nov 15, 2019
@bradzacher
Copy link
Member

Happy to accept a PR

@bradzacher bradzacher added the good first issue Good for newcomers label Nov 15, 2019
@Zjaaspoer
Copy link
Author

👍

@dimabory
Copy link
Contributor

@Zjaaspoer, @bradzacher Seems like it has been merged into eslint a week ago.

@bradzacher bradzacher added external This issue is with another package, not typescript-eslint itself and removed good first issue Good for newcomers labels Nov 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule external This issue is with another package, not typescript-eslint itself package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zjaaspoer @bradzacher @dimabory