Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [no-use-before-define] opt to ignore enum #1242

Merged
merged 7 commits into from Dec 19, 2019
Merged

feat(eslint-plugin): [no-use-before-define] opt to ignore enum #1242

merged 7 commits into from Dec 19, 2019

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1235

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher changed the title feat(eslint-plugin): add an option to ignore enums feat(eslint-plugin): [no-use-before-define] add an option to ignore enums Nov 20, 2019
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 20, 2019
@codecov
Copy link

codecov bot commented Dec 4, 2019 •
edited

Codecov Report

Merging #1242 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
+ Coverage   93.98%   94.01%   +0.03%     
==========================================
  Files         131      131              
  Lines        5864     5867       +3     
  Branches     1662     1662              
==========================================
+ Hits         5511     5516       +5     
+ Misses        187      186       -1     
+ Partials      166      165       -1
Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-use-before-define.ts 98.57% <100%> (+3.04%) ⬆️

bradzacher
bradzacher approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-use-before-define] add an option to ignore enums feat(eslint-plugin): [no-use-before-define] opt to ignore enum Dec 19, 2019
@bradzacher bradzacher merged commit 6edd911 into typescript-eslint:master Dec 19, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Closed
This was referenced Jan 24, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-use-before-define] Add an option to ignore enums
2 participants
@a-tarasyuk @bradzacher