New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [no-empty-interface] noEmptyWithSuper fixer #1247
feat(eslint-plugin): [no-empty-interface] noEmptyWithSuper fixer #1247
Conversation
Thanks for the PR, @dimabory! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this.
two comments for you.
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
- Coverage 94.22% 94.19% -0.04%
==========================================
Files 129 129
Lines 5627 5631 +4
Branches 1581 1582 +1
==========================================
+ Hits 5302 5304 +2
- Misses 180 181 +1
- Partials 145 146 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks
no-empty-interface: 🛠️ Adding fixer for
noEmptyWithSuper
message.Closes #667.