Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-empty-interface] noEmptyWithSuper fixer #1247

Merged

Conversation

dimabory
Copy link
Contributor

@dimabory dimabory commented Nov 21, 2019

no-empty-interface: 🛠️ Adding fixer for noEmptyWithSuper message.

  • Tests

Closes #667.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dimabory!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this.
two comments for you.

packages/eslint-plugin/src/rules/no-empty-interface.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #1247 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
- Coverage   94.22%   94.19%   -0.04%     
==========================================
  Files         129      129              
  Lines        5627     5631       +4     
  Branches     1581     1582       +1     
==========================================
+ Hits         5302     5304       +2     
- Misses        180      181       +1     
- Partials      145      146       +1
Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/no-empty-interface.ts 86.66% <50%> (-13.34%) ⬇️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 22, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-empty-interface] noEmptyWithSuper fixer (#667) feat(eslint-plugin): [no-empty-interface] noEmptyWithSuper fixer Nov 25, 2019
@bradzacher bradzacher merged commit b91b0ba into typescript-eslint:master Nov 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-empty-interface] can't extend Array, "declaring no members is equivalent to its supertype"
2 participants