Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-non-null-assert] add suggestion fixer #1260

Merged
merged 1 commit into from Nov 30, 2019

Conversation

bradzacher
Copy link
Member

Always wanted a fixer for this. A normal fixer won't work because it will cause type errors.
Seems like an awesome opportunity to create a suggestion fixer.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 25, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #1260 into master will decrease coverage by 0.07%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage    94.1%   94.03%   -0.08%     
==========================================
  Files         130      130              
  Lines        5681     5713      +32     
  Branches     1596     1608      +12     
==========================================
+ Hits         5346     5372      +26     
- Misses        182      185       +3     
- Partials      153      156       +3
Impacted Files Coverage Δ
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 0% <ø> (ø) ⬆️
packages/eslint-plugin/src/util/astUtils.ts 92.85% <80%> (-7.15%) ⬇️
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 84.37% <82.75%> (-15.63%) ⬇️

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-non-null-assertion] add suggestion fixer feat(eslint-plugin): [no-non-null-assert] add suggestion fixer Nov 30, 2019
@bradzacher bradzacher merged commit e350a21 into master Nov 30, 2019
@bradzacher bradzacher deleted the no-non-null-assertion-suggest branch November 30, 2019 22:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant