Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-empty-func] private/protected construct #1267

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1178

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #1267 into master will decrease coverage by <.01%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   94.07%   94.06%   -0.01%     
==========================================
  Files         131      131              
  Lines        5737     5746       +9     
  Branches     1616     1618       +2     
==========================================
+ Hits         5397     5405       +8     
+ Misses        184      183       -1     
- Partials      156      158       +2
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/no-empty-function.ts 88.88% <82.35%> (ø) ⬆️

@a-tarasyuk a-tarasyuk force-pushed the feature/1178-no-empty-function-private-constructors-should-not-error branch 2 times, most recently from 629e215 to f775667 Compare November 26, 2019 14:48
@a-tarasyuk a-tarasyuk force-pushed the feature/1178-no-empty-function-private-constructors-should-not-error branch from 83b8ad7 to ae0e8f9 Compare November 26, 2019 16:02
@bradzacher bradzacher added enhancement New feature or request enhancement: plugin rule option New rule option for an existing eslint-plugin rule and removed enhancement New feature or request labels Nov 26, 2019
bradzacher
bradzacher previously approved these changes Nov 26, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise LGTM - thanks

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-empty-function] handle private/protected constructors feat(eslint-plugin): [no-empty-func] private/protected construct Nov 27, 2019
@bradzacher bradzacher merged commit 3b931ac into typescript-eslint:master Nov 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-empty-function] private constructors should not error
2 participants